Repository navigation
Add on-canvas relight light shapes with 3D aim - #1865
Merged
Merged
Conversation
Show every relight light on the canvas while relight is enabled, draw spot lights as a projected cone and directional lights as a disc with parallel rays, and let the aim be dragged from the canvas. Elevation now spans -180 to 180 degrees so lights can also point back at the viewer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013XE47EHfY64AadHeXep5P3
6 of 17 tasks
Owner
|
Wow this looks very nice! Congrats! I will take a look at it soon :) EDIT: Can you remove the code comments please? |
Contributor
Author
Nice!! Sure I'll remove now |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019XviCVbqhgEuFVdZGgf8Ui
Contributor
Author
I've already removed the comments. |
Owner
|
LGTM, thanks for the update! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes the relight lights visible and readable directly on the canvas. Until now a light was only drawn while it was selected in placement mode, every light looked like the same dot, and directional lights had no on-canvas representation at all, so angle, elevation, cone and feather could only be judged from the rendered result.
Lights are now always shown while Relight is enabled, each type has its own shape, and the shape is a 3D projection of the same direction vector the engine uses, so it follows every slider.
Type of Change
Changes Made
overlays/RelightLightShape.tsx):relight.rsand projected through the existing UV-to-canvas mapping, so they respect orientation, flips and rotation. The near half of the rim is solid and the far half dashed.Screenshots/Videos
Testing
Test Configuration:
Checklist
Additional Notes
AI Disclaimer:
Please state the involvement of AI in this PR:
I think this shapes from spot and directional light adds a reference when the user modify the parameters, and helps to be more precise.
The code was written by Claude Code, directed and tested by a human.
🤖 Generated with Claude Code
https://claude.ai/code/session_013XE47EHfY64AadHeXep5P3