Repository navigation
Implement DNG black level delta V correction (Fix for Magenta Coloring of older DNG files) - #1862
Open
borgfriend wants to merge 3 commits into
Open
borgfriend wants to merge 3 commits into
borgfriend wants to merge 3 commits into
Conversation
Added support for DNG black level delta V processing in raw image data.
Owner
|
Please remove the rust tests :) |
| 1.0 | ||
| } | ||
|
|
||
| #[cfg(test)] |
Contributor
There was a problem hiding this comment.
I think it added some tests here.
Co-authored-by: borgfriend <3630448+borgfriend@users.noreply.github.com>
Remove debug-only tests from raw processing module
Owner
|
What do you think regarding the comment here? |
Author
|
Updated to 1.6.5 - problem still persists 
Attached a dng file where you can see the problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for DNG black level delta V processing in raw image data.
Description
Instructed Opus to do an analysis why my oder DNG files were colored magenta.
Instructed it to fix the issue.
Note: It does render the dng correctly but existing preview images are not updated.
This should fix the issues:
#1785
#1542
Type of Change
Changes Made
It added a BlackLevelDeltaV function that only effects the older files.
Screenshots/Videos
Testing
No clue about the tests Opus added them.
Test Configuration:
Checklist
Additional Notes
AI Disclaimer:
Please state the involvement of AI in this PR: