Repository navigation
Conversation
- normalize trailing separators and canonicalize the launch path, so a folder nested in an existing root is selected instead of added as a second root - seed the library roots from settings on a cold start, so opening a folder no longer replaces the existing library roots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open folders passed as launch arguments
Fixes #1176.
RapidRAW previously treated every positional launch argument and macOS
open -a RapidRAW <path>request as an image file. Passing a folder therefore opened it in the external editor flow and failed with “Is a directory”.This change distinguishes directories from files in the launch request path. A folder is added to the library roots when necessary and selected in the library. If it is already inside an existing root, it is selected without creating a duplicate root.
Folder paths are canonicalized (symlinks and trailing separators included), so the same folder is never added twice, and on a cold start the library roots are seeded from the settings before the folder is used — opening a folder no longer replaces the user's existing roots.
How to test
open -a RapidRAW /path/to/photo-folderwhile RapidRAW is closed. The app should open the folder in the library grid.open -a RapidRAW /path/to/another-folder. The window should come forward and switch to that folder.Not changed
--edit/--outputexternal edit sessions are unchanged.