Skip to content

Enable no-unnecessary-condition lint warnings - #1467

Open
cgasgarth wants to merge 2 commits into
CyberTimon:mainfrom
cgasgarth:no-unnecessary-lint-check
Open

Enable no-unnecessary-condition lint warnings#1467
cgasgarth wants to merge 2 commits into
CyberTimon:mainfrom
cgasgarth:no-unnecessary-lint-check

Conversation

@cgasgarth

@cgasgarth cgasgarth commented Aug 4, 2026

Copy link
Copy Markdown

Summary

Change Details
Enable typed lint rule Enables @typescript-eslint/no-unnecessary-condition as a warning.
Error enforcement Adds src/hooks/useSortedLibrary.ts to the error-enforced file list.
Remove redundant checks Removes unnecessary chaining from ImageFile.path and split().
Root config support Allows i18next.config.ts in the TypeScript project service.

Remaining warnings

Warning type Count
Unnecessary optional chain 149
Always-truthy conditional 147
Unnecessary ?? fallback 101
Always-falsy conditional 47
Types have no overlap 10
Always-true literal comparison 4
Total 458

Validation

  • Production build: passes
  • Changed-file formatting: passes
  • Selected file: zero no-unnecessary-condition findings
  • Full lint/typecheck/i18n checks still report pre-existing repository issues outside this change

@cgasgarth
cgasgarth marked this pull request as ready for review August 4, 2026 04:57
@cgasgarth
cgasgarth requested a review from CyberTimon as a code owner August 4, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant