feat: import Lightroom XMP sidecars - #1465
Open
dimafa wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
Calibration update: I tested PR #1465 together with PR #1466’s genuine 16-bit TIFF export. The renderer contract and precision checks passed, but neither tested nonlinear Exposure mapping met the acceptance criteria on fresh validation. So current implementation of the direct 1:1 XMP conversion should stay as implemented in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a Lightroom and Camera Raw XMP sidecar importer for migrating existing edits and metadata into RapidRAW's non-destructive
.rrdataworkflow.This supersedes #1280 and is rebuilt on current
main. Thank you to @StephenMasseur for the original implementation and for agreeing to continue the work in a new PR.The original image and XMP sidecar remain unchanged.
Type of Change
Changes Made
.xmpsidecar next to the image, with a file-picker fallback.Screenshots/Videos
Folder context-menu import action
Import-in-progress indicator
Completed import and unchanged/failed-file report
Testing
Test Configuration:
Validation:
Repository-wide TypeScript, ESLint, formatting, and i18n extraction checks currently report failures that are also reproducible on an unchanged
upstream/main. The importer-specific i18n extraction issue found during development was fixed.Checklist
Additional Notes
Lightroom and RapidRAW use different camera profiles, control scales, tone curves, processing order, and tone-mapping algorithms. Matching numeric adjustment values therefore do not guarantee pixel-identical output.
Calibrated conversion for exposure, contrast, clarity, dehaze, vibrance, white balance, and other profile-dependent adjustments is deliberately excluded from this PR and planned as a separate follow-up.
AI Disclaimer