Skip to content

Bugfix/raw input space - #1457

Open
alexdhill wants to merge 9 commits into
CyberTimon:mainfrom
alexdhill:bugfix/raw_input_space
Open

Bugfix/raw input space#1457
alexdhill wants to merge 9 commits into
CyberTimon:mainfrom
alexdhill:bugfix/raw_input_space

Conversation

@alexdhill

Copy link
Copy Markdown
Contributor

Description

Added raw flag to image model (TaggedImage) to enable easier to manage parsing of image color spaces.

There has been a lot of discussion about the performance and quality of the RAW image color balancing and auto adjustments - some of which I believe is due to the fact certain fns didn't seem to account for the RAW colors (panorama/auto adjust/etc.). I have made some slight patches to account for this - and added some alternative auto-adjustment modes which perform much better in certain scenarios. For consistency, default behaviors have not changed.

When selecting the auto-adjust it acts just as before, but holding on the button will allow you to select other adjustment algorithms (Geometric Mean and Zonal correction). I found zonal works pretty well but performance will likely be dependent on the image itself.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Performance improvement
  • Code refactoring
  • Documentation update
  • UI/UX improvement
  • Build/CI or Dependency update

Changes Made

  • image_processing.rs: new minor fns to handle color space transforms
  • added color_encoding.rs and tagged_image.rs to handle the heavy lifting
  • updated workflows in the following to use the new transformations:
    • culling.rs
    • denoising.rs
    • hdr_deghosting.rs
    • image_loader.rs
    • image_processing.rs
    • panorama_stitching.rs
    • raw_processing.rs
  • Added new auto-balance algorithms to image_processing.rs
  • Added new algorithm selection when holding on auto-balance button in ControlPanel.tsx

Screenshots/Videos

RRauto

Testing

  • I have tested these changes locally and confirmed that they work as expected without issues

Test Configuration:

  • OS: macOS Sequoia
  • Hardware: Intel i5

Checklist

  • My code follows the project's code style
  • I haven't added unnecessary AI-generated code comments
  • My changes generate no new warnings or errors

AI Disclaimer:

Please state the involvement of AI in this PR:

  • This PR is entirely AI-generated
  • This PR is AI-generated but guided by a human
  • This PR was handwritten with AI assistance (spell check, logic suggestions, error resolving)
  • This PR contains only blood, sweat, and coffee (AI-free)

@alexdhill
alexdhill requested a review from CyberTimon as a code owner July 31, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant