Bugfix/raw input space - #1457
Open
alexdhill wants to merge 9 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added raw flag to image model (TaggedImage) to enable easier to manage parsing of image color spaces.
There has been a lot of discussion about the performance and quality of the RAW image color balancing and auto adjustments - some of which I believe is due to the fact certain fns didn't seem to account for the RAW colors (panorama/auto adjust/etc.). I have made some slight patches to account for this - and added some alternative auto-adjustment modes which perform much better in certain scenarios. For consistency, default behaviors have not changed.
When selecting the auto-adjust it acts just as before, but holding on the button will allow you to select other adjustment algorithms (Geometric Mean and Zonal correction). I found zonal works pretty well but performance will likely be dependent on the image itself.
Type of Change
Changes Made
image_processing.rs: new minor fns to handle color space transformscolor_encoding.rsandtagged_image.rsto handle the heavy liftingculling.rsdenoising.rshdr_deghosting.rsimage_loader.rsimage_processing.rspanorama_stitching.rsraw_processing.rsimage_processing.rsControlPanel.tsxScreenshots/Videos
Testing
Test Configuration:
Checklist
AI Disclaimer:
Please state the involvement of AI in this PR: