Conversation
Binary bodies were pushed through the JSON serializer and reached clients as integer arrays. String bodies with non-JSON content types were also incorrectly JSON-quoted. Adds BodyBytes to ScriptResult and a content-type-aware branch in ExtractResponse: byte[] bypasses serialization (octet-stream fallback when no type declared), non-JSON strings pass through raw, and JSON paths keep existing behaviour. Endpoint writers prefer BodyBytes when present. Covers all branches with BinaryResponseTests.
A run re-queued from inside its own context had itself recorded as its own child, causing finalization to deadlock — the run waited on itself to leave _activeRuns, which only happens at finalization. Observed as runs stuck 'Running' for days with every task terminal and Remaining=0. Fixes applied at three layers: - Strip self-parent on run start (CreateOrUpdateRun) - Refuse self-links in TryRegisterChildRun - Skip self-entries in AllChildRunsComplete (guards stale rows from before this fix) - Skip self-links when reattaching child runs on service recovery Adds unit tests covering all three guard layers.
Set `VerbosePreference` and `DebugPreference` to `ActionPreference.Continue` instead of string values in both ISS builders. This preserves the expected typed built-in variables and prevents parameter binding failures when module code forwards values like `-Verbose:$VerbosePreference`.
JohnDuprey
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.