feat(endpoints): add native C# endpoint host - #25
Merged
Merged
Conversation
Introduce opt-in native endpoint discovery, registration, routing, and response/request abstractions so C# handlers can run alongside PowerShell endpoints with configurable collision and concurrency behavior. Also add derived thread-pool minimum sizing, support `Worker:HttpPoolSize=0` for fully native HTTP hosting, update sample configuration, and cover the new endpoint/threading behaviors with tests.
Timer Commands resolve native-first against the discovered [CraftScheduledTask] classes, then fall back to the PowerShell script table unchanged. Native tasks run on the .NET thread pool through the existing JobManager, so priority ordering, job records and the background concurrency limiter apply as-is. A Command present in both worlds fires the native task and logs the shadowed function - same rule, same visibility, as route collisions. IsOrchestratorOverride is rejected on native commands at load and at fire time: the planner/task split is a PowerShell construct, and native code does its own fan-out. Worker:BgPoolSize=0 now builds no BG runspaces, mirroring HttpPoolSize=0. The disabled pool signals ready immediately, so the scheduler still starts; with both sizes 0 the container hosts no PowerShell at all. BgTimeoutSeconds maps to cooperative cancellation for native tasks - documented on the contract, since a task that ignores its token runs on. feat(endpoints): central handler dispatch + native task contracts ICraftEndpointHandler is the native counterpart of Scripts:HttpHandler - one entrypoint every Central-dispatch endpoint routes through, with per-route opt-out declared in code ([CraftEndpoint(Dispatch = Direct)]) for routes that authenticate differently (webhook signatures) or serve anonymous callers deliberately. At most one handler per application; a second fails startup. Zero is legal and preserves today's behaviour. - CraftRequest.Endpoint exposes the attribute so a handler keys authorization off Role, the native .ROLE equivalent - App:Endpoints:RequireHandler fails startup when Central endpoints exist with no handler - the CI gate for apps whose auth lives there - Direct-dispatch routes are enumerated in the startup log - Discovery now returns a catalog (endpoints, handler, scheduled-task contracts, assemblies); service modules are found per assembly rather than per endpoint-bearing assembly - ICraftScheduledTask / [CraftScheduledTask] contracts and discovery land here; the scheduler wires them up in the next commit
Add a shared `CraftJson.Web` serializer options instance and use it as the default for `CraftRequest.ReadJsonAsync` and `CraftResult.Json`. This aligns native endpoint JSON behavior with ASP.NET Core conventions (camelCase output and case-insensitive binding), while still honoring explicitly provided serializer options. Includes focused tests covering camelCase binding, PascalCase compatibility, explicit-option overrides, and raw JSON pass-through.
Standards batch items share FunctionName='CIPPStandard', causing task ID collisions. This fix folds in Standard name, TemplateId, and Settings.TemplateList.value to generate unique IDs — mirroring the key CIPP uses for rerun detection. Also handles Tenant as either a plain domain string or a nested object, and guards TenantFilter extraction against non-string JSON values.
KelvinTegelaar
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce opt-in native endpoint discovery, registration, routing, and response/request abstractions so C# handlers can run alongside PowerShell endpoints with configurable collision and concurrency behavior. Also add derived thread-pool minimum sizing, support
Worker:HttpPoolSize=0for fully native HTTP hosting, update sample configuration, and cover the new endpoint/threading behaviors with tests.