Rename compose tab to "KEYS (COMPOSE)"; size tabs to labels; v3.5.2 - #18
Merged
Conversation
CJ asked for the keys/compose tab to read "KEYS (COMPOSE)" (clearer than the bare "KEYS"). That label is wider than the others, so switch the tab bar from fixed-width to size-to-fit tabs: dix_tab_w() measures each label at the text scale (matching draw_text's 12px/glyph, 8px/space advance) and dix_tab_rect() lays them out left to right. The renderer and the click hit-test both call dix_tab_rect(), so drawing and hit-testing stay in lockstep. Bumps DIX_VERSION to 3.5.2; updates the README tab references. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JpVzsy8Wrc9DYEXns2Njzb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the keys/compose view tab from KEYS to KEYS (COMPOSE) for clarity.
Since that label is wider than the others, the tab bar switches from fixed-width to size-to-fit tabs:
dix_text_w2()measures a label in pixels matchingdraw_text()'s advance (12px/glyph, 8px/space),dix_tab_w()= label width + padding,dix_tab_rect()lays tabs out left to right,mouse-clickedhit-test both calldix_tab_rect(), so drawing and hit-testing can't drift.Bumps
DIX_VERSIONto 3.5.2; README updated. Unit tests pass; v3.5.2 builds, deploys, and loads clean-env.🤖 Generated with Claude Code
Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/