Skip to content

Migrate Form Plugin#357

Merged
benthongtiang merged 13 commits into
masterfrom
ben/FormPlugin
Jul 2, 2026
Merged

Migrate Form Plugin#357
benthongtiang merged 13 commits into
masterfrom
ben/FormPlugin

Conversation

@benthongtiang

Copy link
Copy Markdown
Contributor

Created the new web_view_form plugin structure inside the ABDesigner.
Fix designer display issue

@benthongtiang benthongtiang added bug Something isn't working patch Tag Pull Requests to trigger a patch version update labels Jun 1, 2026
Comment thread src/plugins/web_view_form/FNAbviewform.js Fixed
Comment thread src/plugins/web_view_form/FNAbviewform.js Fixed
Comment thread src/plugins/web_view_form/FNAbviewformEditor.js Fixed

@johnny-hausman johnny-hausman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I realize we'll have future issues with the hard coded links to existing files, but for now we can let those go.


export default function FNAbviewformEditor({ AB, ABViewEditorPlugin }) {
const FABViewContainer =
require("../../rootPages/Designer/editors/views/ABViewContainer").default;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, in the #jh/mcp_server branch, we should pass in this value as it is a hard reference to an existing file.

But this isn't going into that branch, so leave it as is and make a comment to remind me to fix this.

:)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Added a comment to remind you later. Thanks for the review.

@johnny-hausman

Copy link
Copy Markdown
Collaborator

looks like there is probably a recursive loop in our loading of our components.

AB Designer -- Main page -- New application -- Add new application (failed) (attempt 2)

@benthongtiang

Copy link
Copy Markdown
Contributor Author

looks like there is probably a recursive loop in our loading of our components.

AB Designer -- Main page -- New application -- Add new application (failed) (attempt 2)

The E2E test in GitHub is failing because it's running against the older platform code. Once we merge the matching ben/FormPlugin branch in ab_platform_web, the tests will pass.

@benthongtiang benthongtiang merged commit 64f3a8a into master Jul 2, 2026
6 checks passed
@benthongtiang benthongtiang deleted the ben/FormPlugin branch July 2, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working patch Tag Pull Requests to trigger a patch version update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants