made interface consistent - #25
Merged
Merged
Conversation
Contributor
Author
|
@danschmidt5189 this PR implements what we discussed Thursday night. Also, this will not break any of our api code, yay! |
Contributor
There was a problem hiding this comment.
We never call this with a positional $data argument?
Contributor
Author
There was a problem hiding this comment.
We never call this method at all in our api.
Contributor
|
👍 Nice work! |
This is a breaking change. This makes the $data param of the update_charge and update_customer methods a named parameter. This makes all of the update_* methods consistent wrt how the $data param is passed in.
ironcamel
force-pushed
the
interface-cleanup
branch
from
August 3, 2015 18:21
f1c10d3 to
23264b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change. This makes the $data param of the
update_charge and update_customer methods a named parameter. This makes
all of the update_* methods consistent wrt how the $data param is passed in.