Fix star FWHM convention: collapse to standard 2.355*sigma for circular stars - #977
Draft
Cybis320 wants to merge 3 commits into
Draft
Fix star FWHM convention: collapse to standard 2.355*sigma for circular stars#977Cybis320 wants to merge 3 commits into
Cybis320 wants to merge 3 commits into
Conversation
…s, rescale dependent thresholds
Contributor
Author
|
The angular-velocity correction fix referenced above is #978. For typical far-radiant pointing the two errors partially cancel, so the flux impact should be evaluated with both PRs together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The star extractor computes the reported FWHM as the quadrature sum of the two fitted axis sigmas:
For a circular star (σx = σy = σ) this gives 2.355·σ·√2 — 41% larger than the standard FWHM (2.355·σ), the width between the half-maximum points of the profile. The value therefore does not collapse to the textbook definition for round stars. Git archaeology shows the origin:
b1c89067("finished flux engine", Jan 2021) relabeled a pre-existing quadrature-combined "Gaussian stddev" diagnostic as FWHM by multiplying it by 2.355, a conversion only valid for a 1-D sigma.Consequences of the inflated convention
sqrt((mx+my)/(2*flux))) already uses the standard convention, so hand-picked and auto-detected stars carried inconsistent FWHMs in the same paired-star list (blend filtering, match radii).Changes
RMS/ExtractStars.py: FWHM is now2.355*sqrt((sigma_x**2 + sigma_y**2)/2)(RMS mean of the axis sigmas) — collapses to 2.355·σ for circular stars and agrees with SkyFit2's moment-based measurement.DEFAULT_BLEND_FWHM_MULT2.0 → 2.8; SkyFit2 dynamic match radius 1.5×FWHM → 2.1×FWHM; segment-radius auto-tuner margin 1.5 → 2.1; placeholder FWHM fallbacks 2.5 → 1.8.RMS/Formats/CALSTARS.py): files now carry aVersion = 2header line.readCALSTARS()detects the version and normalizes legacy (version 1) files by ÷√2 on read, so all consumers see the standard convention regardless of file age. The −1.0 "no FWHM" sentinel is preserved, and the added header line is ignored by the old parser (fails the numeric parse and is skipped).Utils/Flux.py): the cachedflux_sensor_characterization.jsonis versioned the same way (legacy caches normalized ÷√2 on load), anddefault_fwhmis rescaled 3 → 2.1 to the standard convention.Validation
Science impact (intentional)
Computed fluxes/ZHRs increase by r^0.376 (≈ +30–41%) because the angular-velocity loss term now receives the quantity its derivation calls for. This interacts with the angular-velocity correction fix submitted separately — for typical far-radiant pointing the two errors partially cancel, so they should be evaluated (and ideally merged) together.
🤖 Generated with Claude Code
https://claude.ai/code/session_01B6s6Z27vWeL1Ume1t9AAfz