Align the invoicing sample and projection docs with the language definitions - #23
Merged
Conversation
The sample taught several forms the language definitions reject or deprecate: a redundant projection-level automap (AutoMap is the default), a named sequence its own events never reach, all where every is the correct construct for events the projection subscribes to, a redundant literal keyword on a quoted string, the undocumented set-to alternative to =, an arithmetic mapping referencing a property its source event does not carry, and events used without a declaration or import. The all block moves to a new SystemActivity slice mirroring its documented system-wide use case. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The auto-map page showed an event-level no automap the parser rejects and join/children examples using an events line and an id shorthand that do not exist - joins take with blocks and children require identified by. The grammar page contradicted the parser in the other direction by denying the per-with automap toggle the parser supports, and its closing example used the nonexistent events line. Also add the sequence directive to the projection EBNF. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A quality-assurance pass of the invoicing showcase sample against the actual language definitions, and of the projection documentation against the parser. The sample no longer teaches redundant or rejected forms, and the auto-map/grammar pages now describe exactly what the parser accepts.
Fixed
automap— AutoMap is the defaulteveryinstead ofallfor per-projection mappings, and showcasesallin a new SystemActivity slice matching its documented system-wide semantics=mapping and plain string literalsno automapthe parser rejects, and its join and children examples use the actualwithandidentified byformswithAutoMap toggle and thesequencedirective, and its closing example uses the real join syntax🤖 Generated with Claude Code