Clear transient sign-in handshake cookies on logout - #63
Merged
Conversation
The OAuth/OIDC middleware writes a correlation cookie (and, for OIDC, a nonce cookie) per sign-in handshake. An abandoned handshake leaves one behind, so they accumulate in the browser and were never removed by logout, which cleared only the session and identity cookies. Keep these cookies at the root path so the browser sends them on the logout request, then delete every cookie matching their well-known prefixes when signing out. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
.AspNetCore.Correlation.*,.AspNetCore.OpenIdConnect.Nonce.*) the sign-in handshake leaves behind on abandoned attempts, so signing out no longer leaves them accumulating in the browser. These cookies are now kept at the root path so the browser sends them on the logout request.🤖 Generated with Claude Code