Add analyzer rules for ConceptAs conventions (CRARCH0027, CRARCH0028)

Source/CodeAnalysis.Specs/for_ConceptAsMustHaveNotSetSentinelRule/given/a_conceptasmusthavenotsetssentinelrule.cs

@@ -0,0 +1,8 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+namespace Cratis.Architecture.CodeAnalysis.Specs.for_ConceptAsMustHaveNotSetSentinelRule.given;
+
+public class a_conceptasmusthavenotsetssentinelrule : Cratis.Architecture.CodeAnalysis.Specs.given.an_architecture_analyzer
+{
+}

Source/CodeAnalysis.Specs/for_ConceptAsMustHaveNotSetSentinelRule/when_analyzing_concept_records/and_concept_has_empty_sentinel.cs

@@ -0,0 +1,21 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+namespace Cratis.Architecture.CodeAnalysis.Specs.for_ConceptAsMustHaveNotSetSentinelRule.when_analyzing_concept_records;
+
+public class and_concept_has_empty_sentinel : given.a_conceptasmusthavenotsetssentinelrule
+{
+    async Task Because() =>
+        _diagnostics = await analyze(
+            """
+public record ConceptAs<T>(T Value);
+
+public record AuthorName(string Value) : ConceptAs<string>(Value)
+{
+    public static readonly AuthorName Empty = new(string.Empty);
+}
+""");
+
+    [Fact] void should_not_report_diagnostic() =>
+        _diagnostics.Any(_ => _.Id == "CRARCH0027").ShouldBeFalse();
+}

Source/CodeAnalysis.Specs/for_ConceptAsMustHaveNotSetSentinelRule/when_analyzing_concept_records/and_concept_has_notset_sentinel.cs

@@ -0,0 +1,23 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+namespace Cratis.Architecture.CodeAnalysis.Specs.for_ConceptAsMustHaveNotSetSentinelRule.when_analyzing_concept_records;
+
+public class and_concept_has_notset_sentinel : given.a_conceptasmusthavenotsetssentinelrule
+{
+    async Task Because() =>
+        _diagnostics = await analyze(
+            """
+using System;
+
+public record ConceptAs<T>(T Value);
+
+public record AuthorId(Guid Value) : ConceptAs<Guid>(Value)
+{
+    public static readonly AuthorId NotSet = new(Guid.Empty);
+}
+""");
+
+    [Fact] void should_not_report_diagnostic() =>
+        _diagnostics.Any(_ => _.Id == "CRARCH0027").ShouldBeFalse();
+}

Source/CodeAnalysis.Specs/for_ConceptAsMustHaveNotSetSentinelRule/when_analyzing_concept_records/and_concept_missing_notset_sentinel.cs

@@ -0,0 +1,22 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+namespace Cratis.Architecture.CodeAnalysis.Specs.for_ConceptAsMustHaveNotSetSentinelRule.when_analyzing_concept_records;
+
+public class and_concept_missing_notset_sentinel : given.a_conceptasmusthavenotsetssentinelrule
+{
+    async Task Because() =>
+        _diagnostics = await analyze(
+            """
+using System;
+
+public record ConceptAs<T>(T Value);
+
+public record AuthorId(Guid Value) : ConceptAs<Guid>(Value)
+{
+}
+""");
+
+    [Fact] void should_report_diagnostic() =>
+        _diagnostics.Any(_ => _.Id == "CRARCH0027").ShouldBeTrue();
+}

Source/CodeAnalysis.Specs/for_ConceptAsMustHaveNotSetSentinelRule/when_analyzing_concept_records/and_regular_record_without_notset.cs

@@ -0,0 +1,18 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+namespace Cratis.Architecture.CodeAnalysis.Specs.for_ConceptAsMustHaveNotSetSentinelRule.when_analyzing_concept_records;
+
+public class and_regular_record_without_notset : given.a_conceptasmusthavenotsetssentinelrule
+{
+    async Task Because() =>
+        _diagnostics = await analyze(
+            """
+public record Author(string Name)
+{
+}
+""");
+
+    [Fact] void should_not_report_diagnostic() =>
+        _diagnostics.Any(_ => _.Id == "CRARCH0027").ShouldBeFalse();
+}

Source/CodeAnalysis.Specs/for_GuidConceptMustHaveNewFactoryRule/given/a_guidconceptmusthavenwfactoryrule.cs

@@ -0,0 +1,8 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+namespace Cratis.Architecture.CodeAnalysis.Specs.for_GuidConceptMustHaveNewFactoryRule.given;
+
+public class a_guidconceptmusthavenwfactoryrule : Cratis.Architecture.CodeAnalysis.Specs.given.an_architecture_analyzer
+{
+}

Source/CodeAnalysis.Specs/for_GuidConceptMustHaveNewFactoryRule/when_analyzing_guid_concepts/and_guid_concept_has_new_factory.cs

@@ -0,0 +1,23 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+namespace Cratis.Architecture.CodeAnalysis.Specs.for_GuidConceptMustHaveNewFactoryRule.when_analyzing_guid_concepts;
+
+public class and_guid_concept_has_new_factory : given.a_guidconceptmusthavenwfactoryrule
+{
+    async Task Because() =>
+        _diagnostics = await analyze(
+            """
+using System;
+
+public record ConceptAs<T>(T Value);
+
+public record AuthorId(Guid Value) : ConceptAs<Guid>(Value)
+{
+    public static AuthorId New() => new(Guid.NewGuid());
+}
+""");
+
+    [Fact] void should_not_report_diagnostic() =>
+        _diagnostics.Any(_ => _.Id == "CRARCH0028").ShouldBeFalse();
+}

Source/CodeAnalysis.Specs/for_GuidConceptMustHaveNewFactoryRule/when_analyzing_guid_concepts/and_guid_concept_missing_new_factory.cs

@@ -0,0 +1,22 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+namespace Cratis.Architecture.CodeAnalysis.Specs.for_GuidConceptMustHaveNewFactoryRule.when_analyzing_guid_concepts;
+
+public class and_guid_concept_missing_new_factory : given.a_guidconceptmusthavenwfactoryrule
+{
+    async Task Because() =>
+        _diagnostics = await analyze(
+            """
+using System;
+
+public record ConceptAs<T>(T Value);
+
+public record AuthorId(Guid Value) : ConceptAs<Guid>(Value)
+{
+}
+""");
+
+    [Fact] void should_report_diagnostic() =>
+        _diagnostics.Any(_ => _.Id == "CRARCH0028").ShouldBeTrue();
+}

Source/CodeAnalysis.Specs/for_GuidConceptMustHaveNewFactoryRule/when_analyzing_guid_concepts/and_string_concept_without_new_factory.cs

@@ -0,0 +1,20 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+namespace Cratis.Architecture.CodeAnalysis.Specs.for_GuidConceptMustHaveNewFactoryRule.when_analyzing_guid_concepts;
+
+public class and_string_concept_without_new_factory : given.a_guidconceptmusthavenwfactoryrule
+{
+    async Task Because() =>
+        _diagnostics = await analyze(
+            """
+public record ConceptAs<T>(T Value);
+
+public record AuthorName(string Value) : ConceptAs<string>(Value)
+{
+}
+""");
+
+    [Fact] void should_not_report_diagnostic() =>
+        _diagnostics.Any(_ => _.Id == "CRARCH0028").ShouldBeFalse();
+}

Source/CodeAnalysis/Analyzer.cs

@@ -44,6 +44,10 @@ public partial class ArchitectureAnalyzer : DiagnosticAnalyzer
         LoggerMessageContainerConventionsRule.Descriptor,
         UseCratisFundamentalsTracesRule.Descriptor,
         UseCratisFundamentalsMetricsRule.Descriptor,
+        ConceptAsMustHaveNotSetSentinelRule.Descriptor,
+        GuidConceptMustHaveNewFactoryRule.Descriptor,
+        // TODO: CRARCH0029 - Uncomment when the rule is fully implemented
+        // AvoidPrimitiveTypesRule.Descriptor,
     ];
 
     /// <inheritdoc/>
@@ -61,6 +65,10 @@ public override void Initialize(AnalysisContext context)
         context.RegisterSyntaxNodeAction(AnalyzeMethodDeclaration, SyntaxKind.MethodDeclaration);
         context.RegisterSyntaxNodeAction(AnalyzeIdentifierTypeUse, SyntaxKind.IdentifierName);
         context.RegisterSyntaxNodeAction(AnalyzeMemberAccess, SyntaxKind.SimpleMemberAccessExpression);
+        // TODO: CRARCH0029 - Uncomment these when the rule is fully implemented
+        // context.RegisterSyntaxNodeAction(AnalyzePropertyDeclaration, SyntaxKind.PropertyDeclaration);
+        // context.RegisterSyntaxNodeAction(AnalyzeFieldDeclaration, SyntaxKind.FieldDeclaration);
+        // context.RegisterSyntaxNodeAction(AnalyzeParameter, SyntaxKind.Parameter);
         context.RegisterSyntaxNodeAction(
             AnalyzePrivateModifier,
             SyntaxKind.ClassDeclaration,

Source/CodeAnalysis/AnalyzerReleases.Unshipped.md

@@ -31,3 +31,5 @@ CRARCH0023 | Architecture | Warning | Use typed logger category
 CRARCH0024 | Architecture | Warning | LoggerMessage container conventions
 CRARCH0025 | Architecture | Warning | Use Cratis Fundamentals traces
 CRARCH0026 | Architecture | Warning | Use Cratis Fundamentals metrics
+CRARCH0027 | Architecture | Warning | ConceptAs must have a static readonly NotSet sentinel
+CRARCH0028 | Architecture | Warning | Guid-backed identity concept must have a static New() factory

Source/CodeAnalysis/NamedTypeAnalyzer.cs

@@ -24,6 +24,8 @@ static void AnalyzeNamedType(SymbolAnalysisContext context)
         ExceptionTypeNamingRule.Analyze(context, type);
         NoPostfixesOnClassNamesRule.Analyze(context, type);
         StaticClassNamingConventionRule.Analyze(context, type);
+        ConceptAsMustHaveNotSetSentinelRule.Analyze(context, type);
+        GuidConceptMustHaveNewFactoryRule.Analyze(context, type);
 
         if (type.TypeKind != TypeKind.Class)
         {