Test threshold-breach and feature-branch-push matrix items - #2
Closed
tbjers wants to merge 1 commit into
Closed
Conversation
Adds two new CI verification scenarios: - Push trigger broadened to `test/**` so feature-branch pushes exercise the "Not on default branch — skipping ingest" early-return path. - New `threshold-breach` job (PR-only): sets min-coverage=99, wraps the action step in continue-on-error, then asserts the step outcome is 'failure' — confirming the breach was caught and not silently skipped by an OIDC early-return. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Matrix items verified in CI — closing without merging. The threshold-breach job design is not stable as a permanent fixture; threshold detection is better covered by unit tests in run.test.ts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pushtrigger totest/**so the branch push exercises the feature-branch skip path (Not on default branch — skipping ingest).threshold-breachjob (PR-only) that setsmin-coverage: 99, wraps the action incontinue-on-error, then asserts the step outcome isfailure— confirming the breach is caught rather than silently skipped by an OIDC early-return.What to verify
testjob): Report-metrics step should logNot on default branch (test/matrix-threshold-and-branch ≠ main) — skipping ingest.and the job is green.threshold-breachjob): The action step is red (coverage < 99%), the assert step is skipped, and the overall job is green.testjob): Normal pass withmin-coverage: 20.🤖 Generated with Claude Code