Change Time/Time' to match new database schema and resolve compilation/type errors#1731
Open
Purplegaze wants to merge 11 commits into
Open
Change Time/Time' to match new database schema and resolve compilation/type errors#1731Purplegaze wants to merge 11 commits into
Purplegaze wants to merge 11 commits into
Conversation
… into y-session-fix
…/courseography into y-session-compilation test
Coverage Report for CI Build 0Coverage increased (+0.1%) to 57.459%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
| }) | ||
| }) | ||
|
|
||
| /*** |
Contributor
There was a problem hiding this comment.
Rather than comment out this test, use jest.skip
| getUniqueBuildings = nub . concatMap getMeetBuilding | ||
| where | ||
| getMeetBuildings (MeetTime _ times') = mapMaybe firstLocation' times' ++ mapMaybe secondLocation' times' | ||
| getMeetBuilding (MeetTime _ times') = mapMaybe location' times' |
Contributor
There was a problem hiding this comment.
The function name should not be changed. Multiple buildings can still be returned.
|
|
||
| data Time = | ||
| Time { weekDay :: Double, | ||
| Time { session :: Maybe T.Text, |
Contributor
There was a problem hiding this comment.
Overall I do not want to have session and location reserved for accessor functions for this data type.
Please use the field names timeSession and timeLocation (and timeSession', timeLocation' for Time') and revert the renaming elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Changes the
TimeandTime'datatypes to match the new one-session structure and re-wires them (resolving compilation and type errors) to properly display locations.Currently, there is no logic implemented for courses with two rooms. Because of this, I have temporarily commented out one test in
GetTable.test.jsand left a TODO to re-implement it once this functionality is added....
Screenshots of your changes (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)