Add a wait on stop run and remove running check on delete - #1211
Open
lalepee wants to merge 7 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts runner deletion and run stopping behavior by removing the “running runs” deletion guard and by turning RunStop into a request/response event so the caller can synchronously observe stop completion (via an event response).
Changes:
- Removed the
HasRunningRunspre-check when archiving/deleting a runner. - Converted
RunStoptoCsmRequestResponseEvent<String>and set a response in the stop handler. - Updated
RunnerService.stopLastRunOfto return the stop response (run id) instead of beingUnit.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| runner/src/main/kotlin/com/cosmotech/runner/service/RunnerService.kt | Removes the running-runs delete guard and changes stop API to return a response value. |
| run/src/main/kotlin/com/cosmotech/run/service/RunServiceImpl.kt | Populates RunStop.response when stopping a run. |
| common/src/main/kotlin/com/cosmotech/common/events/RunEvents.kt | Changes RunStop from a fire-and-forget event to a request/response event. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
this could be removed in a major version
jreynard-code
requested changes
Aug 12, 2026
jreynard-code
left a comment
jreynard-code
left a comment
Member
There was a problem hiding this comment.
Some question/validation before merging this PR <3
add log on scheduled task start
lalepee
force-pushed
the
LAL/BUG-async_stop_run-PROD-16436
branch
from
August 13, 2026 13:14
fc4a155 to
f3920e7
Compare
lalepee
force-pushed
the
LAL/BUG-async_stop_run-PROD-16436
branch
from
August 13, 2026 13:21
f3920e7 to
29db5e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.