Lal/keycloak group members prod 16016 - #1203
Conversation
984a2ad to
f925ab3
Compare
f925ab3 to
1f9af68
Compare
sjoubert
left a comment
sjoubert
left a comment
There was a problem hiding this comment.
I think we also need to add tests for all the new endpoints:
- unit/integration tests that check the RBAC requirements
- controller test in the main root module to generate documentation
The merge will also be blocked with the integration of the new keycloak configuration into terraform (maybe the helm chart, but I don't think so) and by the deployment/update of tenant (and the broken CI tenant that needs to be moved from warp to vela) with the new terraform module.
| return keycloak.getAllGroups().map { it.name } | ||
| } | ||
|
|
||
| override fun listKeycloakMembers(): OrganizationMembers { |
There was a problem hiding this comment.
According to the design, shouldn't this be secured behind a Platform.Admin?
There was a problem hiding this comment.
🤔 Actually I'm not sure the security check should be done here. Shouldn't it be handled somewhere in common/src/main/kotlin/com/cosmotech/common/security/AbstractSecurityConfiguration.kt? As well as all the other new endpoints?
Role user and editor have the permission READ_SECURITY, so they should not throw
Runner test on role NONE throw a eroor on PREMISSION_READ before the PERMISSION_READ_SECURITY
| return keycloak.getAllGroups().map { it.name } | ||
| } | ||
|
|
||
| override fun listKeycloakMembers(): OrganizationMembers { |
There was a problem hiding this comment.
🤔 Actually I'm not sure the security check should be done here. Shouldn't it be handled somewhere in common/src/main/kotlin/com/cosmotech/common/security/AbstractSecurityConfiguration.kt? As well as all the other new endpoints?
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
3 participants
This add a link from the API to Keycloak admin which is a different link than the authentication.