Fix a bunch of type annotation mismatch - #515
Merged
Merged
Conversation
This also fixes the default security update logic where it was previously failing because the api ids were passed as a single list arguments instead of separate values
sjoubert
force-pushed
the
fix_type_annotations
branch
from
August 10, 2026 08:21
c57632d to
a314940
Compare
MohcineTor
approved these changes
Aug 10, 2026
MohcineTor
left a comment
MohcineTor
left a comment
Collaborator
There was a problem hiding this comment.
Merci @sjoubert pour ces corrections j’ai juste cette remarque sinon tout est nickel 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes the default security update logic where it was previously failing because the api ids were passed as a single list arguments instead of separate values
I've also changed the
YAMLreader config in the superset helper frombest_map_flow_styletodefault_flow_stylebecause that's the only option I could find, but I'm not really sure, so please take a look at that.