Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #14 and fixes #18.
I have printed a warning in
sample_ode_from_baseandsolve_odes_forwardto catch and alert a user if a negativeatolorrtol(or a tolerance looser than 1e-2) is passed toodeint. I have also changed theno_sigmabehaviour so this is no longer an explicit setting handled by the user. Rather, aVESDEwill by default invokeno_sigma=Falsefor theScoreModelclass, and anything else will default tono_sigma=True. I think these are the optimal choices, and they could be manually overridden if necessary by editing the class attribute.Separately to those two issues, I also adjusted the default
odeintsolver options dictionary, to setmin_stepto 1e-6 as standard. We have historically always done this in our own applications, and it makes the solver more robust against dt underflow errors.