Improve corruption/maulwurf target selection and dice flow with UI highlights#21
Open
CosmicSlothOracle wants to merge 1 commit into
Open
Improve corruption/maulwurf target selection and dice flow with UI highlights#21CosmicSlothOracle wants to merge 1 commit into
CosmicSlothOracle wants to merge 1 commit into
Conversation
✅ Deploy Preview for gleeful-bunny-c4efe6 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
src/App.tsxto track pending abilities and selected target UIDs, listen forpc:corruption_target_selected/pc:maulwurf_select_targetand forwardpc:dice_resultto the engine viapc:corruption_request_rollorpc:maulwurf_request_rollas appropriate.handleCardClickinsrc/App.tsxto allow clicking opponent government cards while a corruption ability is active, dispatch target selection events, and mark a target for a subsequent roll.corruptionTargetUidstate and listeners insrc/components/GameBoard.tsx, extendedrenderCardto add success/fail CSS classes (game-board__card--corruption-success/game-board__card--corruption-fail), and refined slot/card highlight logic so the board highlights selectable targets, the currently selected target, and shows outcome animations on resolution.pc:clear_pending_selection/pc:corruption_resolvedevents and ensure Maulwurf auto-targeting is treated the same for UI highlighting.Testing
npm run buildand the production build completed successfully (compiled successfully, build output generated). — Success.BROWSER=none npm startand verified the app compiles and serves the UI (webpack compiled successfully). — Success.Codex Task