Skip to content

Polish corruption flow, dice UI, victory replay, and expand deck builder#18

Open
CosmicSlothOracle wants to merge 1 commit into
mainfrom
codex/fix-netlify-deployment-issues-5koxab
Open

Polish corruption flow, dice UI, victory replay, and expand deck builder#18
CosmicSlothOracle wants to merge 1 commit into
mainfrom
codex/fix-netlify-deployment-issues-5koxab

Conversation

@CosmicSlothOracle

Copy link
Copy Markdown
Owner

Motivation

  • Fix and polish the corruption mechanics so opponent government cards are highlighted during selection and remain highlighted while the dice roll is in progress, and ensure transfers animate and report success/fail cleanly.
  • Provide clearer dice visuals for corruption probes (rolling, success, fail) and make the victory overlay actionable so players can immediately restart.
  • Increase deck sizes and preset composition to include additional corruption/public/initiative cards and widen deck budget/size ranges for better balance and testing.

Description

  • Engine: emit corruption lifecycle events from the resolver by dispatching pc:corruption_roll_started and pc:corruption_resolved with rich detail so the UI can show hold/highlight and outcome (src/utils/queue.ts).
  • Board UI: listen for those events and keep opponent government slots highlighted during the roll, and apply transient success/fail visuals on the affected card UIDs (src/components/GameBoard.tsx).
  • Dice & app UI: add rolling / success / fail states and CSS styling to the dice container and wire them to the corruption events so the dice shows a highlighted rolling state and a success/fail glow (src/App.tsx, src/App.css).
  • Victory UX: add a "Play again" button to the end-of-game modal and wire it to startNewGame so users can immediately restart (src/components/GameInfoModal.tsx, src/App.tsx).
  • Deck builder & random deck generation: increase deck size limits and budgets (now up to 15 cards, 75-105 BP), inject extra corruption/public/initiative cards into presets, and expand the randomized starting deck generation to 30 cards with some forced specials to ensure corruption/public/initiative presence (src/components/DeckBuilder.tsx, src/hooks/useGameState.ts).
  • Game effect tidy-ups: tighten some effect helpers and ability checks (e.g. diplomat transfer/refactor and require AP in canUsePutinDoubleIntervention) and ensure active-ability application logic avoids marking abilities as applied when nothing happened (src/hooks/useGameEffects.ts, src/utils/effectUtils.ts).
  • UI polish: added spawn animations for newly played cards, corruption success/fail animations, and dice animation keyframes and classes (src/App.css).

Testing

  • Attempted to start the dev server with BROWSER=none npm start, but the run failed due to a missing module error: Cannot find module '/workspace/Milchcards/node_modules/schema-utils/dist/index.js', so the visual/test run could not complete and no runtime verification screenshot was produced.
  • No automated unit tests were run as part of this change set; existing tests were not executed due to the environment/build dependency failure.

Codex Task

@netlify

netlify Bot commented Jan 30, 2026

Copy link
Copy Markdown

Deploy Preview for gleeful-bunny-c4efe6 ready!

Name Link
🔨 Latest commit 69b7a60
🔍 Latest deploy log https://app.netlify.com/projects/gleeful-bunny-c4efe6/deploys/697c8fe7403be10008c83579
😎 Deploy Preview https://deploy-preview-18--gleeful-bunny-c4efe6.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant