Polish corruption flow, dice UI, victory replay, and expand deck builder#18
Open
CosmicSlothOracle wants to merge 1 commit into
Open
Polish corruption flow, dice UI, victory replay, and expand deck builder#18CosmicSlothOracle wants to merge 1 commit into
CosmicSlothOracle wants to merge 1 commit into
Conversation
✅ Deploy Preview for gleeful-bunny-c4efe6 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
pc:corruption_roll_startedandpc:corruption_resolvedwith rich detail so the UI can show hold/highlight and outcome (src/utils/queue.ts).src/components/GameBoard.tsx).src/App.tsx,src/App.css).startNewGameso users can immediately restart (src/components/GameInfoModal.tsx,src/App.tsx).src/components/DeckBuilder.tsx,src/hooks/useGameState.ts).canUsePutinDoubleIntervention) and ensure active-ability application logic avoids marking abilities as applied when nothing happened (src/hooks/useGameEffects.ts,src/utils/effectUtils.ts).src/App.css).Testing
BROWSER=none npm start, but the run failed due to a missing module error:Cannot find module '/workspace/Milchcards/node_modules/schema-utils/dist/index.js', so the visual/test run could not complete and no runtime verification screenshot was produced.Codex Task