Add lightning play-effect and border highlight polish#16
Open
CosmicSlothOracle wants to merge 1 commit into
Open
Add lightning play-effect and border highlight polish#16CosmicSlothOracle wants to merge 1 commit into
CosmicSlothOracle wants to merge 1 commit into
Conversation
✅ Deploy Preview for gleeful-bunny-c4efe6 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
playedfor a brief period usingcollectBoardUids,playedUids, and timeouts insrc/components/GameBoard.tsx, with guards to avoid marking existing cards as new on initial mount.src/App.css(.game-board__card::before,.game-board__card--played::after,@keyframes card-lightning) and wire thegame-board__card--playedclass into the renderer.src/components/GameBoard.tsxby importingPlayer, iterating withArray.from(instead of spread onSet) and addinghasInitializedRefto avoid false positives.src/ui/layout.tsby clamping the UI scale returned bygetUiTransformto1to prevent upscaling of the base layout.src/hooks/useGameEffects.ts(logging hooks, transfer/influence handling tweaks) and a defensive change to ability application flow insrc/utils/effectUtils.tsso abilities only mark state changes when actually applied.Testing
DISABLE_ESLINT_PLUGIN=true BROWSER=none npm start, the app compiled and served successfully (dev server reported "Compiled successfully").TargetClosedError/ SIGSEGV) so an automated screenshot could not be produced.Codex Task