Skip to content

Add lightning play-effect and border highlight polish#16

Open
CosmicSlothOracle wants to merge 1 commit into
mainfrom
codex/fix-netlify-deployment-issues-hapaad
Open

Add lightning play-effect and border highlight polish#16
CosmicSlothOracle wants to merge 1 commit into
mainfrom
codex/fix-netlify-deployment-issues-hapaad

Conversation

@CosmicSlothOracle

Copy link
Copy Markdown
Owner

Motivation

  • Add a short-lived lightning-style visual when a card is placed to make plays feel more responsive and tangible.
  • Improve card border and surface polish so cards read better against the board and highlights are more visible.
  • Fix a couple of small type/transform issues so the visual tracking and UI scaling behave reliably across viewports.

Description

  • Detect newly placed board cards and mark them as played for a brief period using collectBoardUids, playedUids, and timeouts in src/components/GameBoard.tsx, with guards to avoid marking existing cards as new on initial mount.
  • Add a richer card surface, subtle border treatment and a lightning-style pseudo-element animation in src/App.css (.game-board__card::before, .game-board__card--played::after, @keyframes card-lightning) and wire the game-board__card--played class into the renderer.
  • Fix TypeScript indexing/iteration issues and imports in src/components/GameBoard.tsx by importing Player, iterating with Array.from (instead of spread on Set) and adding hasInitializedRef to avoid false positives.
  • Introduce a small UI layout improvement in src/ui/layout.ts by clamping the UI scale returned by getUiTransform to 1 to prevent upscaling of the base layout.
  • Refactor and add optional structured loggers and small logic fixes in src/hooks/useGameEffects.ts (logging hooks, transfer/influence handling tweaks) and a defensive change to ability application flow in src/utils/effectUtils.ts so abilities only mark state changes when actually applied.

Testing

  • Started the dev server with DISABLE_ESLINT_PLUGIN=true BROWSER=none npm start, the app compiled and served successfully (dev server reported "Compiled successfully").
  • Attempted a headless screenshot using Playwright to capture the board visuals, but the Chromium process crashed in this environment (Playwright TargetClosedError / SIGSEGV) so an automated screenshot could not be produced.
  • TypeScript checks completed without remaining errors after the fixes described above.

Codex Task

@netlify

netlify Bot commented Jan 30, 2026

Copy link
Copy Markdown

Deploy Preview for gleeful-bunny-c4efe6 ready!

Name Link
🔨 Latest commit 0335b13
🔍 Latest deploy log https://app.netlify.com/projects/gleeful-bunny-c4efe6/deploys/697c3ab0c4732d0008a80702
😎 Deploy Preview https://deploy-preview-16--gleeful-bunny-c4efe6.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant