Ship-critical fixes: GET endpoints, domain exceptions, health check#9
Merged
Conversation
…docs
Major fixes to make the template production-ready:
- Wire CQRS query adapters to API routers (GET /work-items, GET /work-items/{id},
GET /integration-jobs, GET /integration-jobs/{id} with status filtering)
- Replace ValueError with domain-specific NotFoundError exceptions
(WorkItemNotFoundError, IntegrationJobNotFoundError)
- Add /health endpoint
- Consistent error handling across both bounded contexts
(NotFoundError->404, InvalidTransition->409, InvalidEmail->422)
- Update CLAUDE.md with CQRS query pattern, API layer, updated workflow
- Update README with accurate test count, API docs, curl examples
- Update .claude/rules/application-rules.md with CQRS guidance
- Add MIT LICENSE file
- 78 tests (up from 67), all passing
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValueErrorwithWorkItemNotFoundError/IntegrationJobNotFoundErrordomain exceptions/healthendpoint for deployment readiness.claude/rules/application-rules.mdwith CQRS query guidanceTest plan
make all-checkspasses🤖 Generated with Claude Code