Skip to content

Fix broken AVX2 cmov that skips FO implicit rejection (key recovery) #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
007bsd wants to merge 1 commit into from
Closed

Fix broken AVX2 cmov that skips FO implicit rejection (key recovery) #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/avx2/verify.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,9 @@ pub fn verify(a: &[u8], b: &[u8], mut len: usize) -> u8 {

pub fn cmov(r: &mut [u8], x: &[u8], mut len: usize, mut b: u8) {
let (mut xvec, mut rvec);
b = b.wrapping_neg();
unsafe {
let bvec = _mm256_set1_epi64x(b as i64);
let bvec = _mm256_set1_epi8(b as i8);
for i in 0..(len / 32) {
rvec = _mm256_loadu_si256(r[32 * i..].as_ptr() as *const __m256i);
xvec = _mm256_loadu_si256(x[32 * i..].as_ptr() as *const __m256i);
Expand All @@ -34,7 +35,6 @@ pub fn cmov(r: &mut [u8], x: &[u8], mut len: usize, mut b: u8) {
}
let idx = 32 * (len / 32);
len -= idx;
b = b.wrapping_neg();
for i in 0..len {
r[idx + i] ^= b & (x[idx + i] ^ r[idx + i]);
}
Expand Down