CI: standardize Actions (paths + concurrency + runners)#8
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
The plugin was changed to read the `protocol` field from the init message (commit 9552b5c), but test/test.sh still sent `version`, so every test saw an empty protocol and failed with "Unsupported protocol version". Update both init messages to use `protocol`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Addresses CodeQL code-scanning alert about GITHUB_TOKEN permissions not being limited in the test workflow. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/test.yml— the repo had abin/entrypoint andtest/suite but NO build/test CI (only a Pages deploy). Shell logic and protocol tests were unverified on PR.main, scoped viapaths: [bin/**, test/**, .github/workflows/test.yml]so docs/README-only changes trigger nothing.concurrency:grouptest-${{ github.ref }}withcancel-in-progress: true.ubuntu-latest(GitHub-hosted) — correct for a PUBLIC repo; never self-hosted.bash -nsyntax check onbin/fledge-localnet+test/test.sh, then runs the self-contained protocol test suite./test/test.sh.actions/checkout@v5,timeout-minutes: 10.pages.ymlleft unchanged — already correct (paths-scoped todocs/**, concurrency, github-hosted).Mirrors the CorvidLabs/merlin CI standard.