Skip to content

fix: unblock manual recall metadata patching#926

Open
TurboTheTurtle wants to merge 1 commit into
CortexReach:masterfrom
TurboTheTurtle:codex/issue-925-manual-recall-metadata
Open

fix: unblock manual recall metadata patching#926
TurboTheTurtle wants to merge 1 commit into
CortexReach:masterfrom
TurboTheTurtle:codex/issue-925-manual-recall-metadata

Conversation

@TurboTheTurtle

Copy link
Copy Markdown
Contributor

Summary

  • return manual memory_recall results before best-effort access-metadata patches settle
  • preserve the existing governance patch and resolved scope filter
  • log rejected background patches without changing a successful recall result
  • cover stalled and rejected metadata writes with focused regression tests

Fixes #925

Verification

  • node --test test/recall-text-cleanup.test.mjs test/auto-recall-timeout.test.mjs test/memory-governance-tools.test.mjs — 41 passed
  • npm run verify-package-runtime
  • npm run test:packaging-and-workflow
  • git diff --check

@app3apps app3apps left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed head f547fc5. Moving best-effort access metadata patches off the manual-recall response path directly addresses the reported timeout, matches the established auto-recall pattern, and the full test suite passes. I found no blocking issue.

Non-blocking follow-ups:

  • The detached patch also resets suppression/governance fields, not only telemetry, so the code comment should describe the broader best-effort semantics.
  • Deferral widens the read-modify-write window for access_count, which can undercount closely sequenced recalls.

The branch is behind current master, but GitHub currently reports it as clean and mergeable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

memory_recall blocks on best-effort access metadata writes

2 participants