fix: unblock manual recall metadata patching#926
Open
TurboTheTurtle wants to merge 1 commit into
Open
Conversation
app3apps
approved these changes
Jul 12, 2026
app3apps
left a comment
There was a problem hiding this comment.
Reviewed head f547fc5. Moving best-effort access metadata patches off the manual-recall response path directly addresses the reported timeout, matches the established auto-recall pattern, and the full test suite passes. I found no blocking issue.
Non-blocking follow-ups:
- The detached patch also resets suppression/governance fields, not only telemetry, so the code comment should describe the broader best-effort semantics.
- Deferral widens the read-modify-write window for
access_count, which can undercount closely sequenced recalls.
The branch is behind current master, but GitHub currently reports it as clean and mergeable.
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
memory_recallresults before best-effort access-metadata patches settleFixes #925
Verification
node --test test/recall-text-cleanup.test.mjs test/auto-recall-timeout.test.mjs test/memory-governance-tools.test.mjs— 41 passednpm run verify-package-runtimenpm run test:packaging-and-workflowgit diff --check