Hermes Connector 0.2.2 — real browser fix and verified release - #2
Hermes Connector 0.2.2 — real browser fix and verified release#2CorsenAI wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9805ec2fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!(Object.hasOwn(changeInfo || {}, "url") || Object.hasOwn(changeInfo || {}, "pendingUrl") || | ||
| Object.hasOwn(changeInfo || {}, "status"))) return; | ||
| scheduleAttachedTabRefresh(tabId); | ||
| if (tab && tab.active) scheduleActiveTabBroadcast(tabId, tab); |
There was a problem hiding this comment.
When the active tab of a background Chrome window navigates, tab.active is still true because activity is scoped per window. Passing that tab directly to scheduleActiveTabBroadcast bypasses the lastFocusedWindow query, so the panel can present the background-window tab as “current”; pressing Attach then fails the expectedTabId check and the display remains misleading until another refresh event. Verify that the updated tab belongs to the last-focused window before broadcasting it.
Useful? React with 👍 / 👎.
1 participant
Résumé
Validation
Déploiement
Ne pas fusionner les Pages avant coordination avec l'approbation Chrome Web Store 0.2.2. La release GitHub fournit d'abord le compagnon exact requis par l'extension soumise.