Skip to content

fix(auth): fail closed on dev key and version blobs - #88

Merged
yi-here merged 1 commit into
Continuum-AI-Corp:mainfrom
hasitpbhatt:fix/cred-encryption-guard
Aug 27, 2026
Merged

fix(auth): fail closed on dev key and version blobs#88
yi-here merged 1 commit into
Continuum-AI-Corp:mainfrom
hasitpbhatt:fix/cred-encryption-guard

Conversation

@hasitpbhatt

@hasitpbhatt hasitpbhatt commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Orca-Code-Review — push 1

Severity Count
P0 0
P1 0
P2 0
P3 0

✅ no blocking findings

Stacked from fix/startup-secret-logging split.

  • encryption: versioned v1, legacy compat, explicit InvalidTag
  • guards: fail-closed via inspect, re-raises transient errors
  • config: allow_insecure_dev_key
  • main: invoke guard after create_all
  • tests: versioned, truncated, guard cases

Covers P2 and P3 plus Linus fixes.
Rebased on 9021c8f.

@orcacode-review orcacode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳 OrcaCode Review

No findings — nothing to flag in this PR. Great work!

OrcaCode Review — Route Smarter. Ship Safer. Spend Less.
Engine-reported: 246 calls · 10.2M tokens · 97% cached

❤️ Share · Install OrcaCode Review

Free on GitHub — the review runs on your own OrcaRouter key. If it helped, a shout-out goes a long way.

Share: X · Reddit · LinkedIn
Follow: X · Discord · LinkedIn · OrcaRouter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants