Re-wire the Spotlight deep-link reveal onto the UIKit timeline#136
Merged
Conversation
…6.19) The M7 rewrite left ui.spotlightTargetTakeID dangling: only the pinned-Obie row path still read it (flash only, never cleared), the collection never consumed it, and no scroll-to-item existed — a Spotlight tap opened the app and visibly did nothing. - UIKitTimelineViewController gains requestReveal/attemptReveal: scroll the target row to centre, pulse the card ember (flashingID -> reconfigure -> cell overlay, 0.4s ease both edges), then fire onRevealHandled so the host clears the one-shot state. A reveal whose row isn't in the snapshot yet stays pending and resolves on a later apply. - TimelineReadCell/TimelineSwipeCell thread isSpotlightTarget; the overlay is render-only (same ember 0.18 treatment as the old row flash). - DailiesView passes the target (filtering out the pinned Obie, which is not a collection row) and clears the Obie case itself after its rowContent flash pulses. - handleSpotlight: the existence check only runs while UNLOCKED — a cold Spotlight tap lands on the locked app where the store is the empty placeholder, and the old guard silently dropped the target, so the most common path (tap -> Face ID -> timeline) never navigated. The pending reveal now resolves after unlock; a deleted Take's reveal simply never fires. Needs device review: scroll landing position, pulse visibility both modes, and the locked -> unlock -> reveal flow. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the parked mid-point-review item: tapping a Catchlight result in iOS Spotlight now navigates to the Take.
ui.spotlightTargetTakeID: scrolls the row to centre, pulses the card with the ember accent (same 0.18 treatment as the old SwiftUI flash), then clears the one-shot state — so a re-tap on the same Take re-targets (the old path never cleared it).Tests
🤖 Generated with Claude Code