Fix SNOOZED marker on the UIKit timeline (D-058/D-060 regression)#132
Merged
Conversation
The label lane picks its word from `isSnoozed ? "SNOOZED" : "OVERDUE"`, but the rewritten timeline never wired snooze through: `TimelineReadCell` didn't pass isSnoozed and `UIKitTimeline` never received the snoozed set — so every snoozed overdue Take read "OVERDUE". Snooze isn't derivable from the Take (it lives in `vm.snoozedReminderIDs`), which is exactly why the rebuild dropped it — found while re-anchoring the Feature Register after the M7 merge. Thread `snoozedIDs` from DailiesView → UIKitTimeline → the cells, with its OWN reconfigure trigger: a snooze doesn't change the Take's value, so the value-diff that reconfigures cells couldn't see it (same shape as the month-filter restyle). Diff the set instead. Owner-verified on device: a snoozed Take now reads SNOOZED, and flips the moment it's snoozed without needing another edit to that Take. (The reorder-coverage + register-anchor work from the same local pass is already on main via PR #131 — its `reorderTarget` extraction and test file are byte-identical to what that PR landed, so nothing to add here.) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
The Take label lane picks its word from
isSnoozed ? "SNOOZED" : "OVERDUE". The Pillar 2 rewrite (PR #130) never wired snooze through to the new timeline —TimelineReadCelldidn't takeisSnoozed, andUIKitTimelinenever received the snoozed set at all — so every snoozed overdue Take read "OVERDUE" (regression against D-058/D-060).Snooze isn't derivable from a
Take— it lives invm.snoozedReminderIDs— which is exactly why the rebuild dropped it. Found while re-anchoring the code-anchored Feature Register after the M7 merge (the "Overdue / snoozed states" row pointed atTakeRowView.isSnoozed, which now only renders the pinned Obie).The fix
Thread
snoozedIDsfromDailiesView→UIKitTimeline→TimelineSwipeCell→TimelineReadCell→TakeCardSurface, with its own reconfigure trigger: a snooze doesn't change the Take's value, so the value-diff that reconfigures cells couldn't see it (a snoozed card would keep saying OVERDUE until something else touched that Take). The collection now diffs the snoozed set — the same pattern the month-filter restyle uses.Scope note
This was originally part of a larger local pass that also restored the reorder-maths test coverage and re-anchored the Feature Register. PR #131 landed the reorder work independently while this was in flight — its
reorderTargetextraction andBlockEditorReorderGeometryTestsare byte-identical to what that pass produced, so this PR is scoped to the SNOOZED fix alone. The register (non-git docs) is already re-anchored.Verification
Owner-verified on device: a snoozed Take reads SNOOZED, and flips the moment it's snoozed with no further edit. 357 Core tests pass; app + device builds clean.
🤖 Generated with Claude Code