Skip to content

ci: Pin actions and fix SonarCloud - #578

Merged
FrederikBolding merged 4 commits into
mainfrom
fb/fix-ci
Aug 12, 2026
Merged

ci: Pin actions and fix SonarCloud#578
FrederikBolding merged 4 commits into
mainfrom
fb/fix-ci

Conversation

@FrederikBolding

@FrederikBolding FrederikBolding commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

This PR addresses two things:


Note

Medium Risk
Touches deploy, npm publish, and AWS credential workflows plus SonarCloud scan invocation, so incorrect pins or scan-action differences could break CI/CD or coverage reporting.

Overview
Pins GitHub Actions to commit SHAs across build, deploy, publish, release, and terraform workflows, aligning with Consensys org security requirements.

Migrates SonarCloud scanning in build-lint-test.yml from a manually downloaded SonarScanner CLI to the pinned SonarSource/sonarqube-scan-action, using projectBaseDir for starknet-snap and wallet-ui.

Reviewed by Cursor Bugbot for commit 80a8e7d. Bugbot is set up for automated code reviews on this repo. Configure here.

BGos87 and others added 4 commits May 12, 2026 14:55
Pin every `uses:` ref in .github/workflows and composite actions to a
full 40-character commit SHA, with the original tag preserved as a
comment, e.g.

    uses: actions/checkout@11bd719 # v4

Tags and branches are mutable; commit SHAs are not. Pinning to a SHA
closes a supply-chain vector where a compromised action could replace
what runs in CI without changing the tag we reference.

Generated mechanically with `pinact run`
(https://github.com/suzuki-shunsuke/pinact). No version bumps were
applied (strict pin).
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@FrederikBolding FrederikBolding changed the title wip: Fix CI ci: Pin actions and fix SonarCloud Aug 12, 2026
@FrederikBolding
FrederikBolding marked this pull request as ready for review August 12, 2026 13:12
@FrederikBolding
FrederikBolding requested review from a team as code owners August 12, 2026 13:12
@FrederikBolding
FrederikBolding merged commit 22d6b75 into main Aug 12, 2026
20 of 28 checks passed
@FrederikBolding
FrederikBolding deleted the fb/fix-ci branch August 12, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants