Skip to content

ci: do not install goimports and asmfmt - #883

Merged
ivokub merged 1 commit into
masterfrom
ci/install-goimports
Sep 13, 2026
Merged

ivokub merged 1 commit into
masterfrom
ci/install-goimports

Conversation

@ivokub

@ivokub ivokub commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Description

We now use them as go tools and the version is pinned in go.mod. No need to install the running @latest in CI job.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran or implemented to verify your changes. Provide instructions so we can reproduce.

  • Test A
  • Test B

How has this been benchmarked?

Please describe the benchmarks that you ran to verify your changes.

  • Benchmark A, on Macbook pro M1, 32GB RAM
  • Benchmark B, on x86 Intel xxx, 16GB RAM

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Note

Low Risk
Workflow-only change that drops duplicate tool installs; formatting checks still use pinned go tool entries from go.mod.

Overview
Removes the test job step that ran go install for goimports and asmfmt at @latest in .github/workflows/pr.yml.

Static checks already invoke go tool goimports, and both tools are pinned via go.mod, so the extra install was redundant and could drift from the repo’s pinned versions.

Reviewed by Cursor Bugbot for commit 6ebfbbc. Bugbot is set up for automated code reviews on this repo. Configure here.

Signed-off-by: Ivo Kubjas <ivo.kubjas@consensys.net>
@ivokub
ivokub merged commit 5dec634 into master Sep 13, 2026
17 of 18 checks passed
@ivokub
ivokub deleted the ci/install-goimports branch September 13, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant