ci: do not install goimports and asmfmt - #883
Merged
Merged
Conversation
Signed-off-by: Ivo Kubjas <ivo.kubjas@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We now use them as go tools and the version is pinned in go.mod. No need to install the running
@latestin CI job.Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran or implemented to verify your changes. Provide instructions so we can reproduce.
How has this been benchmarked?
Please describe the benchmarks that you ran to verify your changes.
Checklist:
golangci-lintdoes not output errors locallyNote
Low Risk
Workflow-only change that drops duplicate tool installs; formatting checks still use pinned
go toolentries from go.mod.Overview
Removes the test job step that ran
go installforgoimportsandasmfmtat@latestin.github/workflows/pr.yml.Static checks already invoke
go tool goimports, and both tools are pinned viago.mod, so the extra install was redundant and could drift from the repo’s pinned versions.Reviewed by Cursor Bugbot for commit 6ebfbbc. Bugbot is set up for automated code reviews on this repo. Configure here.