fix(eddsa): generate bandersnatch/eddsa on Bandersnatch instead of Ju… - #882
Merged
ivokub merged 1 commit intoSep 13, 2026
Merged
Conversation
…bjub Fixes Consensys-Incorporated#881 Signed-off-by: Reno <renaud.dubois.fr@gmail.com>
ivokub
self-requested a review
September 13, 2026 21:26
ivokub
approved these changes
Sep 13, 2026
Contributor
|
Thanks for the PR! |
Contributor
Author
|
Np, It also requires the mirror one in gnark to be merged as well. |
rdubois-crypto
added a commit
to ZKNoxHQ/gnark
that referenced
this pull request
Sep 14, 2026
…ch EdDSA test Depends on Consensys-Incorporated/gnark-crypto#882 Signed-off-by: Reno <renaud.dubois.fr@gmail.com>
rdubois-crypto
added a commit
to ZKNoxHQ/gnark
that referenced
this pull request
Sep 14, 2026
…Incorporated/gnark-crypto#882) Signed-off-by: Reno <renaud.dubois.fr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #881
Note
High Risk
Corrects which curve EdDSA uses for Bandersnatch, changing keys and signatures relative to the previous buggy output—security-critical for any consumer of this package.
Overview
Fixes #881: generated
ecc/bls12-381/bandersnatch/eddsawas wired to Jubjub (twistededwards) instead of Bandersnatch, so keys and signatures were not on the intended curve.The EdDSA code generator now keeps
conf.Packageas the curve name (twistededwardsorbandersnatch) for template imports, still emits theeddsaGo package under each curve directory, and templates importecc/{{.Name}}/{{.Package}}(with atwistededwardsalias when the package isbandersnatch). Regenerated Bandersnatch EdDSA sources and docs reflect Bandersnatch.Adds hand-written
TestBandersnatchKATwith fixed public key, coordinates, signature, on-curve check, and verify—locking behavior to Bandersnatch and documenting the old Jubjub public key for the same seed.Reviewed by Cursor Bugbot for commit 52703b2. Bugbot is set up for automated code reviews on this repo. Configure here.