Skip to content

Use as_chunks for star catalogue iteration - #72

Merged
vanlueckn merged 1 commit into
mainfrom
t3code/596fb3ef
Aug 20, 2026
Merged

Use as_chunks for star catalogue iteration#72
vanlueckn merged 1 commit into
mainfrom
t3code/596fb3ef

Conversation

@vanlueckn

Copy link
Copy Markdown
Collaborator

Summary

  • Replace chunks_exact() with as_chunks::<RECORD>().0 for type-safe fixed-size chunking in star mesh generation
  • as_chunks is const-generic and returns exactly-sized chunks, eliminating runtime iteration edge cases
  • Simpler and more idiomatic Rust for fixed-size records

Testing

  • Verify star mesh renders correctly in the 3D view
  • Confirm no visual differences in star positions, brightness, or color
  • Not run: integration tests (no existing test suite appears to cover sky rendering)

Rust 1.98 clippy flags chunks_exact with a constant size
(clippy::chunks_exact_to_as_chunks), which broke CI with -D warnings.
@vanlueckn
vanlueckn merged commit 9a1958f into main Aug 20, 2026
3 checks passed
@vanlueckn
vanlueckn deleted the t3code/596fb3ef branch August 20, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant