Torque converter fill dynamics with droop and primary influence - #20
Merged
Conversation
Add converter absorption slope λ(ν), separate drain/fill times, and speed governor droop to model realistic hydraulic transmission behavior: - Engine governor droop: set speed sags under load, follows converter demand - Circuit absorption λ(ν) = λ·(1 + slope·ν) models pump load variation with slip - Separate fill_time and drain_time: outgoing converter empties faster, creates the hole in tractive effort at the change point - Primary influence: shift point moves with notch (full power vs zero throttle) - steady_force() computes actual tractive effort curve from engine map and converter geometry — change point and all - suggest() derives starting parameters from five data sheet figures - Updated vehicle specs (BR 218, railcar) and comprehensive tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
cargo test -p sim-core): Torque-Ratio-Tests, Absorptions-Trend, Primärbeeinflussung, Steady-Curve-Verhalten, Suggestion-Landungcargo test -p i18n): en/main.ftl und de/main.ftl enthalten alle neuen Schlüsselcontent::vehicles::br218()konfiguriert mit Werten aus dem Diff, Railcar analog aktualisiertgov-droop,trm-drain-time,cir-absorption-slope,cir-shift-primary