Repository navigation
fix: define content and redaction convergence while suppressed writes retain older RVs #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # A final bookkeeping-only revision of cm-app.v1: visible data stays the same. | ||
| # Every built-in projection ignores these added managedFields and last-applied metadata. | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| uid: cm-app-0001 | ||
| name: app-config | ||
| namespace: app | ||
| resourceVersion: "1002" | ||
| managedFields: | ||
| - manager: bookkeeping | ||
| operation: Apply | ||
| apiVersion: v1 | ||
| fieldsType: FieldsV1 | ||
| fieldsV1: {} | ||
| labels: | ||
| app.kubernetes.io/name: shop | ||
| annotations: | ||
| note: keep | ||
| kubectl.kubernetes.io/last-applied-configuration: '{"apiVersion":"v1","kind":"ConfigMap"}' | ||
| data: | ||
| log-level: info | ||
| replicas: "3" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # The same Secret under `krm-full/v1`: values are omitted from the object. The accompanying event's | ||
| # `redacted` entries declare which paths exist upstream, allowing the client to render them as | ||
| # read-only without introducing a placeholder value. | ||
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| uid: secret-token-0001 | ||
| name: git-creds | ||
| namespace: app | ||
| resourceVersion: "4002" | ||
| labels: | ||
| app.kubernetes.io/name: shop | ||
| type: Opaque |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # Final token rotation: username and all visible content are unchanged except RV. | ||
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| uid: secret-token-0001 | ||
| name: git-creds | ||
| namespace: app | ||
| resourceVersion: "4002" | ||
| labels: | ||
| app.kubernetes.io/name: shop | ||
| type: Opaque | ||
| data: | ||
| token: bmV3LXRva2Vu # "new-token"; still withheld | ||
| username: Ym9i # "bob" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| id: final-bookkeeping-only | ||
| title: A final bookkeeping-only write leaves visible content converged and the held RV older. | ||
| why: > | ||
| Spec §6 excludes metadata.resourceVersion from convergence. The final upstream write changes only | ||
| ignored managedFields and last-applied metadata plus RV. No later visible write refreshes the RV. | ||
| suites: [gateway, client] | ||
| scope: { target: demo, version: v1, resource: configmaps, namespace: app } | ||
| projection: krm-full/v1 | ||
| watch: | ||
| - { op: list, bodies: [cm-app.v1] } | ||
| - { op: modified, body: cm-app.v2-bookkeeping } | ||
| events: | ||
| - { type: reset } | ||
| - { type: added, body: cm-app.v1 } | ||
| - { type: synced } | ||
| client: | ||
| expect: | ||
| uids: [cm-app-0001] | ||
| dirty: [] | ||
| conflicts: [] | ||
| draftSubset: | ||
| metadata: { resourceVersion: "1001" } | ||
| data: { log-level: info, replicas: "3" } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| id: final-redaction-rotation | ||
| title: A final Secret rotation must deliver its changed redaction revision. | ||
| why: > | ||
| Spec §6 includes redaction records in the visible comparison. The final token rotation leaves | ||
| projected content excluding RV unchanged, but its changed redaction revision MUST reach the client. | ||
| No later write or snapshot can repair a missed rotation; the hidden token must remain absent. | ||
| suites: [gateway, client] | ||
| scope: { target: demo, version: v1, resource: secrets, namespace: app } | ||
| projection: krm-full/v1 | ||
| watch: | ||
| - { op: list, bodies: [secret-token.v1] } | ||
| - { op: modified, body: secret-token.v2 } | ||
| events: | ||
| - { type: reset } | ||
| - type: added | ||
| body: secret-token.v1-wire | ||
| redacted: [{ path: "/data/token", rev: 1 }, { path: "/data/username", rev: 1 }] | ||
| - { type: synced } | ||
| - type: modified | ||
| body: secret-token.v2-wire | ||
| redacted: [{ path: "/data/token", rev: 2 }, { path: "/data/username", rev: 1 }] | ||
| client: | ||
| expect: | ||
| uids: [secret-token-0001] | ||
| dirty: [] | ||
| conflicts: [] | ||
| draftSubset: | ||
| metadata: { resourceVersion: "4002" } | ||
| absentPaths: [[data]] | ||
| readOnlyPaths: [[data, token], [data, username]] | ||
| patch: null |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Qualify the browser credential guarantee.
README.mdsays that the browser never receives a Kubernetes credential. However,docs/adopting.mdLines 123-128 andpackages/krm-stream/README.mdLines 56-60 document an intentionally token-bearing browser mode. Scope this sentence to the default host-owned cookie flow. Otherwise, the documentation gives users an incorrect security boundary.Proposed wording
🤖 Prompt for AI Agents