Repository navigation
feat: upgrade krm-stream, enforce shared rate limits, and reconcile docs - #31
Merged
Merged
Conversation
…ith its user krm-stream 0.7.0 took asks 9, 10 and 13 of docs/investigations/krm-stream-shared-watches.md. - Ask 9: a shared watch opens outside the gateway's backend-wide lock, under a context its waiting streams share. krm-foyer's workaround, which opened it on the first Next, is gone; TestAStuckOpeningHoldsUpNoOtherScope stays, fails against 0.6.0, and now fails rather than hangs. - Ask 10: krm-stream refuses timed rechecks without a write timeout. krm-foyer always set one; a server test checks that every route in front of a stream lets it flush and set write deadlines, over HTTP/1.1 and HTTP/2. - Ask 13: the decision cache's key cites the review attributes krm-stream now documents, and the guard test also checks the subresource. The hello example vendors the 0.7.0 browser bundle, which differs only in its version. Every refusal is now one "refused" log line with by (krm-foyer or kubernetes), the user as the issuer named them, route, method, path and reason: krm-foyer's interruptions below 500, the API server's 401, 403, 409 and 422 on /k8s, and a stream's FORBIDDEN, UNAUTHENTICATED and SCOPE_INVALID with the scope. An interruption from 500 stays an "interruption" line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 10 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (34)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared-watch traffic could exceed
-shared-watch-qps: Kubernetes clients had separate rate budgets, and client-go bypasses its limiter when opening watches. Charge access reviews, watch openings, fallback lists and retries to one transport-level budget, with cancellation and request-body cleanup tested.This also upgrades krm-stream to 0.7.0, removes the superseded lazy-watch workaround, and records refusals once with the user and refusing component. Documentation now distinguishes implemented behavior from planned features, labels historical investigations, corrects deployment/security/streaming guarantees, and orders the remaining work around deployment, capacity, a second application, refresh, shared storage and release maintenance. CI now runs the existing vendor check alongside lint.
This PR includes the prerequisite upgrade from #29 so the complete reviewed result can be tested and merged against
main. It overlaps that PR; the separate Helm chart work is excluded.Validation:
task verify(tidy/vendor checks, lint, unit/race tests, fuzzing, browser-helper tests, container smoke tests and Kubernetes/Dex/browser e2e). Seven pre-existing pending e2e specifications remain pending and are documented as gaps.