Repository navigation
feat: Audit only, the right (but harder) way - #122
Merged
Merged
Conversation
…ting to run claude and codex both)
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (20 files)
The PR properly removes the correlation webhook infrastructure and replaces it with the audit stream consumer approach as documented in the design files. The GitTarget validator webhook is correctly preserved for preventing duplicate target configurations. Reviewed by minimax-m2.5 · 605,297 tokens |
…es (especailly arround deletion of objects).
… run serious, we do have some requirements).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important simplification in how gitops-reverser gets its audit events: it's now a requirement that you configure the Kubernetes API Server to push audit events through a webhook. This is annoying, but it's the only way to get the commit author 100% right. It all boils down to not being able to guarantee a validation webhook wasn't stopped for whatever reason after you processed it. The real audit event only triggers after everything is successfully stored.
Working list: