cmd/baton: remove Hidden flag from rollback-expansion command#962
Open
btipling wants to merge 1 commit into
Open
cmd/baton: remove Hidden flag from rollback-expansion command#962btipling wants to merge 1 commit into
btipling wants to merge 1 commit into
Conversation
The rollback-expansion subcommand was registered with Hidden: true, making it invisible in baton --help output despite being compiled in and fully functional. Remove the Hidden field so the command is discoverable via help. Co-authored-by: c1-squire-dev[bot] <c1-squire-dev[bot]@users.noreply.github.com>
Contributor
General PR Review: cmd/baton: remove Hidden flag from rollback-expansion commandBlocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0 Review SummaryThis PR removes the Security IssuesNone found. Correctness IssuesNone found. SuggestionsNone. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ggreer
approved these changes
Jun 16, 2026
ggreer
left a comment
ggreer
left a comment
Contributor
There was a problem hiding this comment.
Maybe in the help, mention that this should only be used if you know what you're doing. Is there any use case where a customer would want to undo grant expansion on a c1z?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
rollback-expansionsubcommand was registered withHidden: trueincmd/baton/rollback_expansion.go, which suppressed it from appearing inbaton --helpoutput. The command is compiled in and fully functional;hiding it makes it undiscoverable to users.
This change removes the
Hidden: truefield so the command appears inthe standard help listing alongside other subcommands.
Built with stargate.