Skip to content

Real interface for list grants by principal. #953

Open
mj-palanker wants to merge 5 commits into
mainfrom
mjp/list-grant-by-principal
Open

Real interface for list grants by principal. #953
mj-palanker wants to merge 5 commits into
mainfrom
mjp/list-grant-by-principal

Conversation

@mj-palanker

Copy link
Copy Markdown
Contributor

Exposing the by principal listing will enable performant new user grant uplift.

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

General PR Review: Real interface for list grants by principal.

Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0
Review mode: incremental since 05af067
View review run

Review Summary

The new commits add a defensive validation guard in C1File.ListGrantsForPrincipal that rejects requests missing a principal_id (preventing unfiltered full-table scans), mirrors the existing Pebble adapter guard, adds tests for both engines, and documents why UnimplementedGrantsReaderServiceServer was deliberately removed from the Pebble adapter embed list. No new issues found.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

None.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

@mj-palanker mj-palanker marked this pull request as ready for review June 16, 2026 20:00
@mj-palanker mj-palanker requested a review from a team June 16, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant