[CXP-688] docs: remove SCIM configuration references from AWS connector docs#131
Open
c1-squire-dev[bot] wants to merge 1 commit into
Open
[CXP-688] docs: remove SCIM configuration references from AWS connector docs#131c1-squire-dev[bot] wants to merge 1 commit into
c1-squire-dev[bot] wants to merge 1 commit into
Conversation
SCIM support was intentionally removed in #104 once user status became available directly from the Identity Store API. The connector docs still referenced the now-removed SCIM configuration, so remove: - The "Enable usage of the AWS IAM Identity Center SCIM API" mention from the IAM-setup guidance - The optional SCIM setup step in the SSO web-UI flow - The BATON_SCIM_ENABLED / BATON_SCIM_ENDPOINT / BATON_SCIM_TOKEN env vars from the Kubernetes secret example Also drop the three dead SCIM struct fields (SCIMToken, SCIMEndpoint, SCIMEnabled) left behind in pkg/connector/connector.go by #104 — they are declared but never read or written. Fixes CXP-688. Co-authored-by: c1-squire-dev[bot] <c1-squire-dev[bot]@users.noreply.github.com>
Contributor
Connector PR Review: docs: remove SCIM configuration references from AWS connector docsBlocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0 Review SummaryScanned the full PR diff for security and correctness. This change removes obsolete SCIM references from Security IssuesNone found. Correctness IssuesNone found. SuggestionsNone. |
johnallers
approved these changes
Jun 27, 2026
luisina-santos
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the now-obsolete SCIM configuration references from the AWS connector documentation (
docs/connector.mdx).SCIM was intentionally removed from the connector in #104 — it was only ever used to fetch SSO user status, which became available directly from the Identity Store API (
UserStatus) in Nov 2025. The docs were not updated at the time and still pointed users at SCIM settings that no longer exist.Changes
docs/connector.mdx:BATON_SCIM_ENABLED/BATON_SCIM_ENDPOINT/BATON_SCIM_TOKENenvironment variables from the Kubernetes secret example.pkg/connector/connector.go:Configstruct fields (SCIMToken,SCIMEndpoint,SCIMEnabled) left behind by cxp-232 take sso user status from api response #104. They are declared but never read or written anywhere in the repo.Verification
grep -ri scim docs/→ no matches remain.go build ./...andgo vet ./pkg/connector/pass.Fixes CXP-688.