Skip to content

[CXP-688] docs: remove SCIM configuration references from AWS connector docs#131

Open
c1-squire-dev[bot] wants to merge 1 commit into
mainfrom
john.allers/CXP-688/remove-scim-doc-references
Open

[CXP-688] docs: remove SCIM configuration references from AWS connector docs#131
c1-squire-dev[bot] wants to merge 1 commit into
mainfrom
john.allers/CXP-688/remove-scim-doc-references

Conversation

@c1-squire-dev

@c1-squire-dev c1-squire-dev Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

What

Removes the now-obsolete SCIM configuration references from the AWS connector documentation (docs/connector.mdx).

SCIM was intentionally removed from the connector in #104 — it was only ever used to fetch SSO user status, which became available directly from the Identity Store API (UserStatus) in Nov 2025. The docs were not updated at the time and still pointed users at SCIM settings that no longer exist.

Changes

docs/connector.mdx:

  • Drop the "Enable usage of the AWS IAM Identity Center SCIM API" mention from the IAM-setup guidance (the "DO NOT click…" line).
  • Remove the optional SCIM setup step ("To enable C1 to sync the statuses of Identity Center accounts…") from the SSO web-UI configuration flow.
  • Remove the BATON_SCIM_ENABLED / BATON_SCIM_ENDPOINT / BATON_SCIM_TOKEN environment variables from the Kubernetes secret example.

pkg/connector/connector.go:

Verification

  • grep -ri scim docs/ → no matches remain.
  • go build ./... and go vet ./pkg/connector/ pass.

Fixes CXP-688.

SCIM support was intentionally removed in #104 once user status became
available directly from the Identity Store API. The connector docs still
referenced the now-removed SCIM configuration, so remove:

- The "Enable usage of the AWS IAM Identity Center SCIM API" mention from
  the IAM-setup guidance
- The optional SCIM setup step in the SSO web-UI flow
- The BATON_SCIM_ENABLED / BATON_SCIM_ENDPOINT / BATON_SCIM_TOKEN env vars
  from the Kubernetes secret example

Also drop the three dead SCIM struct fields (SCIMToken, SCIMEndpoint,
SCIMEnabled) left behind in pkg/connector/connector.go by #104 — they are
declared but never read or written.

Fixes CXP-688.

Co-authored-by: c1-squire-dev[bot] <c1-squire-dev[bot]@users.noreply.github.com>
@c1-squire-dev c1-squire-dev Bot requested a review from a team June 27, 2026 13:48
@linear-code

linear-code Bot commented Jun 27, 2026

Copy link
Copy Markdown

CXP-688

@github-actions

Copy link
Copy Markdown
Contributor

Connector PR Review: docs: remove SCIM configuration references from AWS connector docs

Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base 1461605cbb3c.
Review mode: full
View review run

Review Summary

Scanned the full PR diff for security and correctness. This change removes obsolete SCIM references from docs/connector.mdx and deletes three dead Config struct fields (SCIMToken, SCIMEndpoint, SCIMEnabled) from pkg/connector/connector.go. A repo-wide grep confirms no remaining SCIM references in any non-vendor Go source or docs, so the removed fields and env vars are genuinely dead and the docs now match the connector behavior. No new issues found.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

None.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

@johnallers johnallers requested a review from a team June 27, 2026 13:53
@luisina-santos luisina-santos changed the title docs: remove SCIM configuration references from AWS connector docs [CXP-688] docs: remove SCIM configuration references from AWS connector docs Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants