chore(config): move AppStoreSource off the deprecated IConfig app-value API

[rubenvdlinde]

Completes what the ForgeRegistry PR started. OCP\IConfig::getAppValue and setAppValue are @deprecated 29.0.0 in favour of IAppConfig. 92 -> 87, and versioniq now has no deprecated app-value call left anywhere.

This one could not be a straight swap, which is exactly why it was held back: AppStoreSource also calls getSystemValueString, which exists only on IConfig. So it now takes both — IConfig purely for the system value, IAppConfig for the five app values.

The part worth reviewing

The new parameter goes after the existing IConfig one, and all five test constructions are positional, so every one is updated in the same commit. Adding a parameter mid-signature without walking the call sites is how a green suite turns into Argument #N must be of type X at runtime.

The stubs move with the calls: getAppValue -> getValueString, setAppValue -> setValueString. setValueString returns bool where setAppValue returned void, so those callbacks now return true — a void callback would have handed PHPUnit a null for a bool return type.

Verification

vendor/bin/psalm 5.26.1 on PHP 8.3: 92 -> 87 with the baseline emptied, regenerated baseline green, and the five stale DeprecatedMethod entries are gone rather than merely unused. PHPUnit not run locally (needs the server bootstrap).

[github-actions]

Quality Report — ConductionNL/versioniq @ 870ada9

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	✅
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		✅
stylelint		✅
build		✅
composer			✅	✅ 29/29
npm			✅	✅ 302/302
app:check-code	⏭️
info.xml	✅
REUSE	❌
PHPUnit					✅
Newman					⏭️
Playwright					⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development
Hydra gates					✅

---

Quality workflow — 2026-08-31 18:59 UTC

Download the full PDF report from the workflow artifacts.