fix(deps): @nextcloud/vite-config 3.0.0-beta.1 — development cannot npm ci after vite 8 - #272
Merged
Merged
Conversation
…pm ci #267 merged vite 8.2.2 while @nextcloud/vite-config stayed at 2.5.4, which declares a hard peer of vite ^7.3.6. npm ci on development now fails with ERESOLVE before a single job runs, taking every frontend check with it: eslint, stylelint, Frontend Build, Frontend Tests, Security (npm), License (npm) and the Playwright E2E job. 3.0.0-beta.1 (dist-tag 'next') is the first release whose peer range accepts vite 8 (>=8.2). 2.x will never accept it, and there is no stable 3.x yet — the alternative is reverting vite to ^7.3.6. Verified with node 22 / npm 11.19 against this exact tree: npm ci, vite build, vitest (11 files / 58 tests), eslint and stylelint all pass. The emitted bundle file set is unchanged from the vite 7 baseline apart from the css chunk content hash.
Contributor
Quality Report — ConductionNL/versioniq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| composer | ✅ | ✅ 29/29 | |||
| npm | ✅ | ✅ 310/310 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | 🚨 NO VERDICT — enabled but never ran | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-30 09:10 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#267 merged
vite7.3.6 -> 8.2.2, but left@nextcloud/vite-configat^2.5.4, which declares a hard peer ofvite: ^7.3.6.npm ciondevelopmentnow fails with ERESOLVE before any job body runs:That takes out every frontend check at once: Vue Quality (eslint), Vue Quality (stylelint), Frontend Build, Frontend Tests (unit), Security (npm), License (npm) and E2E Tests (Playwright). Reproduced locally against
origin/developmentat 1412a47.Why this fix
@nextcloud/vite-config2.x will never accept vite 8 — the peer is pinned.3.0.0-beta.1(npm dist-tagnext, published 2026-08-19) is the first release whose peer range isvite: >=8.2. There is no stable 3.x yet.The alternative is reverting
viteto^7.3.6and re-closing #267. Happy to do that instead if a prerelease build toolchain is not acceptable — versioniq is the only fleet app on@nextcloud/vite-config; every other app builds with webpack, which is why buildiq's identical vite 8 bump was trivially green.Verification (node 22 / npm 11.19, against this exact tree)
npm cidevelopment)npm run buildnpm testnpm run lintnpm run stylelintEmitted bundle file set is unchanged from the vite 7 baseline (
js/versioniq-main.mjs,.mjs.license,.mjs.map,css/versioniq-main.css,css/main-<hash>.chunk.css) apart from the css chunk content hash.Scope is dev-only:
@nextcloud/vite-configis a build tool, not shipped runtime code.