Release: merge development into beta - #368
Merged
Merged
Conversation
…tHub
TWO STALE FACTS IN ONE FILE.
Version: this manifest said 0.1.3-unstable.17 — a whole major behind the
app it describes. The newest stable tag is v1.0.0, the 1.1.0 line was
already opened as v1.1.0-beta.0 and v1.1.0-beta.1, and apps.nextcloud.com
currently serves 1.1.0-beta.1. It survived because the release workflows
rewrite the version in the BUILT package instead of reading this value, so
the number that ships was always right and this one was never consulted.
Forge links: website, bugs, repository and all three screenshots named
Codeberg, which the fleet dropped on 2026-08-19. Every one still answered
200 from a stale mirror, which is exactly why it lasted — a dead link gets
found, a live link to a tracker nobody reads does not. Each screenshot URL
was checked on the new host before being swapped: all three answer 200
image/png from raw.githubusercontent on `main`.
WHAT THIS DOES NOT FIX, so nobody reads it as the cure: nldesign's App
Store upload fails 403 {"detail":"You do not have permission to perform
this action."} That is ownership, not numbering — the token is not a
maintainer of this app on the store, which is consistent with 1.1.0-beta.1
and 1.0.0 both having been published from Codeberg URLs. The computed beta
version is a SEPARATE problem and is also not fixed here: the workflow
derives it as "newest stable tag, patch+1", so with v1.0.0 as the newest
stable tag it keeps emitting 1.0.1-beta.<ts>, which sorts BELOW the store's
1.1.0-beta.1. Moving that needs a stable tag >= v1.1.0, which is a release
decision rather than a manifest edit.
Verified: XSD-valid against apps.nextcloud.com/schema/apps/info.xsd; zero
`codeberg` strings remain; and the release workflow's own extraction now
returns exactly "1.1.0".
That last check earned its place. The explanatory comment originally wrote
the opening version tag literally in its prose, and the workflow's
lookbehind takes the FIRST match in the file — so it read " in the" as the
version. The rewrite that quoted the grep command in order to WARN about
this reintroduced it and read ")[^". The comment now carries the warning
without ever writing the tag, and the assertion above is what caught both.
chore(appinfo): bump version to 1.1.0 and point forge links at GitHub
Contributor
Author
Quality Report — ConductionNL/nldesign @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 2/2 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-21 06:22 UTC
Download the full PDF report from the workflow artifacts.
rubenvdlinde
approved these changes
Aug 21, 2026
rubenvdlinde
left a comment
Contributor
There was a problem hiding this comment.
Approving development → beta.
Measured: 3 pull_request-event workflows at fcff294, 38 jobs, 0 failed,
0 cancelled — judged on the LATEST run per workflow, so a superseded
attempt's cancelled jobs cannot linger as a false failure.
Carries appinfo/info.xml's bump to 1.1.0 and the move of every forge link
from the retired Codeberg to GitHub. This promotion is the point of that
change rather than a formality: beta is what releases, so the version and
the App Store listing metadata have no effect while they sit only on
development.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR to sync development changes to beta for beta release.
Merging this PR will trigger the beta release workflow.