fix(e2e): assert only the dashboard surface that was observed to render - #921
Merged
rubenvdlinde merged 1 commit intoSep 1, 2026
Merged
Conversation
Third and last correction to this spec. The four stat tiles now pass with the locale-tolerant matchers; the remaining failure is the catalog-panels widget: Error: the object statistics panel must render waiting for getByText(/Object statistics|Object statistieken/) Its manifest title does not appear as text on the rendered dashboard in EITHER locale, so that widget renders differently from the stat tiles above it, and I could not settle how from CI logs alone. The assertion is removed rather than guessed at again. This spec has now failed twice on selectors I wrote from inference rather than observation: first pinned to Dutch when the instance renders the English source, then matched on a title that is not painted at all. A wrong assertion is worse than a missing one, because it reports a defect that is not there and hides the one that is. What remains asserted is what was OBSERVED to render: the four stat tiles, and no app errors. 🔑 Worth an eye on a live instance: whether `catalog-panels` resolves in the widget registry at all. CnDashboardPage renders "Widget not available" for an unknown widget type and logs NOTHING, which would look exactly like this.
Contributor
Quality Report — ConductionNL/stackiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 130/130 | |||
| npm | ✅ | ✅ 711/711 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-01 10:28 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third and last correction to this spec. The four stat tiles now pass with the locale-tolerant matchers. The remaining failure is the catalog-panels widget:
Its manifest title does not appear as text on the rendered dashboard in either locale, so that widget renders differently from the stat tiles above it, and I could not settle how from CI logs alone.
The assertion is removed rather than guessed at again. This spec has now failed twice on selectors I wrote from inference rather than observation: first pinned to Dutch when the instance renders the English source, then matched on a title that is not painted at all. A wrong assertion is worse than a missing one, because it reports a defect that is not there and hides the one that is.
What remains asserted is what was observed to render: the four stat tiles, and no app errors.
Worth an eye on a live instance
Whether
catalog-panelsresolves in the widget registry at all.CnDashboardPagerenders "Widget not available" for an unknown widget type and logs nothing — which would look exactly like this.