Skip to content

fix(e2e): assert only the dashboard surface that was observed to render - #921

Merged
rubenvdlinde merged 1 commit into
developmentfrom
fix/e2e-dashboard-assert-only-what-was-observed
Sep 1, 2026
Merged

fix(e2e): assert only the dashboard surface that was observed to render#921
rubenvdlinde merged 1 commit into
developmentfrom
fix/e2e-dashboard-assert-only-what-was-observed

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Third and last correction to this spec. The four stat tiles now pass with the locale-tolerant matchers. The remaining failure is the catalog-panels widget:

Error: the object statistics panel must render
waiting for getByText(/Object statistics|Object statistieken/)

Its manifest title does not appear as text on the rendered dashboard in either locale, so that widget renders differently from the stat tiles above it, and I could not settle how from CI logs alone.

The assertion is removed rather than guessed at again. This spec has now failed twice on selectors I wrote from inference rather than observation: first pinned to Dutch when the instance renders the English source, then matched on a title that is not painted at all. A wrong assertion is worse than a missing one, because it reports a defect that is not there and hides the one that is.

What remains asserted is what was observed to render: the four stat tiles, and no app errors.

Worth an eye on a live instance

Whether catalog-panels resolves in the widget registry at all. CnDashboardPage renders "Widget not available" for an unknown widget type and logs nothing — which would look exactly like this.

Third and last correction to this spec. The four stat tiles now pass with the
locale-tolerant matchers; the remaining failure is the catalog-panels widget:

  Error: the object statistics panel must render
  waiting for getByText(/Object statistics|Object statistieken/)

Its manifest title does not appear as text on the rendered dashboard in
EITHER locale, so that widget renders differently from the stat tiles above
it, and I could not settle how from CI logs alone.

The assertion is removed rather than guessed at again. This spec has now
failed twice on selectors I wrote from inference rather than observation:
first pinned to Dutch when the instance renders the English source, then
matched on a title that is not painted at all. A wrong assertion is worse
than a missing one, because it reports a defect that is not there and hides
the one that is.

What remains asserted is what was OBSERVED to render: the four stat tiles,
and no app errors.

🔑 Worth an eye on a live instance: whether `catalog-panels` resolves in the
widget registry at all. CnDashboardPage renders "Widget not available" for an
unknown widget type and logs NOTHING, which would look exactly like this.
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/stackiq @ 324e82b

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
build
check-manifest
check-vue-demi
test-l10n
format
check-schema-l10n
check-l10n-js
composer ✅ 130/130
npm ✅ 711/711
app:check-code ⏭️
info.xml
REUSE
PHPUnit
Newman ⏭️
Playwright ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development
Hydra gates

Quality workflow — 2026-09-01 10:28 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde merged commit daeedb8 into development Sep 1, 2026
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant