Skip to content

fix(e2e): match the dashboard labels in either locale #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenvdlinde merged 1 commit into from
Sep 1, 2026
Merged

fix(e2e): match the dashboard labels in either locale #918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions tests/e2e/spec-coverage/dashboard.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,19 +31,28 @@ test('dashboard: renders the overview surface (stat tiles and the object statist
// heading; that surface was replaced when the KPI tiles landed, and this
// spec kept asserting the old one.
//
// Labels are asserted in DUTCH because the e2e instance runs Dutch, and
// they are NOT all identical to the manifest source: the manifest says
// "Services" and nl.json maps it to "Diensten". Asserting the English
// source here would pass only on an English instance.
for (const label of ['Organisaties', 'Modules', 'Diensten', 'Contracten']) {
// Matched against BOTH the manifest source and its nl.json translation.
// Two of these differ between the two: the manifest says "Services" and
// "Object statistics", which nl.json maps to "Diensten" and "Object
// statistieken". Pinning either one couples the spec to whichever locale
// the instance happens to boot in, and that is exactly how the previous
// version of this test failed: it asserted Dutch against an instance
// rendering the English source.
const tiles: RegExp[] = [
/Organisaties/,
/Modules/,
/Services|Diensten/,
/Contracten/,
]
for (const label of tiles) {
await expect(
main.getByText(label, { exact: false }).first(),
`the ${label} stat tile must render`,
main.getByText(label).first(),
`the ${label.source} stat tile must render`,
).toBeVisible({ timeout: 30000 })
}

await expect(
main.getByText('Object statistieken', { exact: false }).first(),
main.getByText(/Object statistics|Object statistieken/).first(),
'the object statistics panel must render',
).toBeVisible({ timeout: 30000 })

Expand Down
Loading