chore(icons): adopt the Tier B vocabulary in full - #895
Merged
Conversation
gate-60 reported 8 Tier B warnings, four concepts duplicated across the real and mock register. All adopted. 8 -> 0. Vulnerability ShieldAlert -> ShieldAlertOutline Contract FileDocumentEdit -> FileSign Connection Link -> TransitConnectionVariant View Eye -> EyeOutline Contract is the substantive one: FileDocumentEdit is a document being EDITED, which is the opposite of what a signed contract is. FileSign says signed.⚠️ TransitConnectionVariant and EyeOutline had to be REGISTERED in src/icons.js in the same commit. Neither was there, and an icon a manifest names but the registry does not hold renders as NOTHING, not a fallback.
Contributor
Quality Report — ConductionNL/stackiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 130/130 | |||
| npm | ✅ | ✅ 711/711 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-09-01 05:10 UTC
Download the full PDF report from the workflow artifacts.
The icon PR could not go green because stackiq development is red on its own account. All three are pre-existing, not introduced here. 1. Frontend Check (format): prettier flagged src/components/CatalogPanels.vue, a file this PR never touched. It has been failing on development since #892. Reformatted with the repo own config; the whole tree now reports "All matched files use Prettier code style!". 2. gate-60 icon-vocabulary FAILED, not warned: FileDocument and Web are named by src/manifest.json but were absent from src/icons.js, so both rendered as NOTHING. Registered. 3. gate-102 manifest-l10n-coverage: three manifest strings had no nl.json key, so they rendered English to a Dutch user. Two of them were the opposite problem, hardcoded DUTCH in a manifest whose menu labels are all English (Dashboard, Organisations, Applications, Suites, Services), so an English user saw Dutch: "Diensten" -> "Services" nl.json already had Services: Diensten "Object statistieken" -> "Object statistics" + new key "Modules" + new key, same word either way Only title and label were touched. The id, route and name values keep "Diensten" because they are identifiers, not copy.⚠️ The keys were added to BOTH l10n/nl.json and l10n/nl.js. The browser reads the .js; a key in the .json alone is invisible to the user and check:l10n would still call the two in sync. Verified by loading nl.js and diffing the key sets: 760 each, 0 in one and not the other. Sentence case per the Conduction voice rules, not Title Case.
Contributor
Quality Report — ConductionNL/stackiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 130/130 | |||
| npm | ✅ | ✅ 711/711 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-01 05:31 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gate-60 reported 8 Tier B warnings — four concepts duplicated across the real and mock register. All adopted. 8 -> 0.
Contractis the substantive one:FileDocumentEditis a document being edited, which is the opposite of what a signed contract is.FileSignsays signed.TransitConnectionVariantandEyeOutlinehad to be registered insrc/icons.jsin the same commit. Neither was there, and an icon a manifest names but the registry does not hold renders as nothing, not a fallback.