Skip to content

fix(e2e): close the .vs__search class in catalog-ratings too #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenvdlinde merged 3 commits into from
Aug 30, 2026
Merged

fix(e2e): close the .vs__search class in catalog-ratings too #841

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3dc9f1a
fix(e2e): .vs__search is a wrapper now, not the input
rubenvdlinde Aug 30, 2026
cbd93d3
Merge remote-tracking branch 'origin/development' into fix/ncselect-s…
rubenvdlinde Aug 30, 2026
384bc79
style: Prettier the selector change
rubenvdlinde Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tests/e2e/spec-coverage/catalog-ratings.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,13 @@ async function submitReview(
.getByRole('textbox', { name: /^Title/ })
.first()
.fill(reviewTitle)
const rater = dialog.locator('.vs__search').first()
// `.vs__search` no longer identifies the input on its own: the component
// library now also puts that class on a wrapper, so `.first()` resolved to
// <div class="input-field input-field--label-outside vs__search">
// and `fill()` refused it with "Element is not an <input>, <textarea>,
// <select> or [contenteditable]". Demand an actual input, whether the class
// sits on it or on an ancestor, so this survives the markup moving again.
const rater = dialog.locator('input.vs__search, .vs__search input').first()
await rater.click()
await page
.locator('.vs__dropdown-option', { hasText: new RegExp(`^${rating}$`) })
Expand Down
Loading